Skip to content

Commit 87c3de7

Browse files
committed
dcp, dcmp, dsync, dchmod: update progress messages
Signed-off-by: Adam Moody <[email protected]>
1 parent c119ca1 commit 87c3de7

File tree

6 files changed

+315
-277
lines changed

6 files changed

+315
-277
lines changed

src/common/mfu_flist_archive.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ static void reduce_fini(const void* buf, size_t size)
263263
}
264264

265265
/* print status to stdout */
266-
MFU_LOG(MFU_LOG_INFO, "%s %.3lf %s (%.0f\%) in %.3lf secs (%.3lf %s) %.0f secs left ...",
266+
MFU_LOG(MFU_LOG_INFO, "%s %.3lf %s (%.0f%%) in %.3lf secs (%.3lf %s) %.0f secs left ...",
267267
reduce_opstr, val_tmp, val_units, percent, secs, rate_tmp, rate_units, secs_remaining
268268
);
269269
}
@@ -2211,12 +2211,12 @@ static void create_progress_fn(const uint64_t* vals, int count, int complete, in
22112211

22122212
if (complete < ranks) {
22132213
MFU_LOG(MFU_LOG_INFO,
2214-
"Tarred %.3lf %s (%.0f\%) in %.3lf secs (%.3lf %s) %.0f secs left ...",
2214+
"Tarred %.3lf %s (%.0f%%) in %.3lf secs (%.3lf %s) %.0f secs left ...",
22152215
bytes_val, bytes_units, percent, secs, bw_val, bw_units, secs_remaining
22162216
);
22172217
} else {
22182218
MFU_LOG(MFU_LOG_INFO,
2219-
"Tarred %.3lf %s (%.0f\%) in %.3lf secs (%.3lf %s) done",
2219+
"Tarred %.3lf %s (%.0f%%) in %.3lf secs (%.3lf %s) done",
22202220
bytes_val, bytes_units, percent, secs, bw_val, bw_units
22212221
);
22222222
}
@@ -4144,12 +4144,12 @@ static void extract2_progress_fn(const uint64_t* vals, int count, int complete,
41444144

41454145
if (complete < ranks) {
41464146
MFU_LOG(MFU_LOG_INFO,
4147-
"Extracted %llu items and %.3lf %s (%.0f\%) in %.3lf secs (%.3lf items/sec, %.3lf %s) %.0f secs left ...",
4147+
"Extracted %llu items and %.3lf %s (%.0f%%) in %.3lf secs (%.3lf items/sec, %.3lf %s) %.0f secs left ...",
41484148
vals[REDUCE_ITEMS], bytes_val, bytes_units, percent, secs, item_rate, bw_val, bw_units, secs_remaining
41494149
);
41504150
} else {
41514151
MFU_LOG(MFU_LOG_INFO,
4152-
"Extracted %llu items and %.3lf %s (%.0f\%) in %.3lf secs (%.3lf items/sec, %.3lf %s) done",
4152+
"Extracted %llu items and %.3lf %s (%.0f%%) in %.3lf secs (%.3lf items/sec, %.3lf %s) done",
41534153
vals[REDUCE_ITEMS], bytes_val, bytes_units, percent, secs, item_rate, bw_val, bw_units
41544154
);
41554155
}
@@ -4188,12 +4188,12 @@ static void extract1_progress_fn(const uint64_t* vals, int count, int complete,
41884188

41894189
if (complete < ranks) {
41904190
MFU_LOG(MFU_LOG_INFO,
4191-
"Extracted %.3lf %s (%.0f\%) in %.3lf secs (%.3lf %s) %.0f secs left ...",
4191+
"Extracted %.3lf %s (%.0f%%) in %.3lf secs (%.3lf %s) %.0f secs left ...",
41924192
bytes_val, bytes_units, percent, secs, bw_val, bw_units, secs_remaining
41934193
);
41944194
} else {
41954195
MFU_LOG(MFU_LOG_INFO,
4196-
"Extracted %.3lf %s (%.0f\%) in %.3lf secs (%.3lf %s) done",
4196+
"Extracted %.3lf %s (%.0f%%) in %.3lf secs (%.3lf %s) done",
41974197
bytes_val, bytes_units, percent, secs, bw_val, bw_units
41984198
);
41994199
}

src/common/mfu_flist_chmod.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1194,9 +1194,6 @@ void mfu_flist_chmod(
11941194
/* set bits on items starting at the deepest level, this is so we still get child items
11951195
* in the case that we're disabling bits on the parent items */
11961196
for (int level = levels - 1; level >= 0; level--) {
1197-
/* start timer for this level */
1198-
double start = MPI_Wtime();
1199-
12001197
/* spread items for this level evenly over all procs */
12011198
mfu_flist list = mfu_flist_spread(lists[level]);
12021199

@@ -1218,24 +1215,6 @@ void mfu_flist_chmod(
12181215

12191216
/* wait for all processes to finish before we start with files at next level */
12201217
MPI_Barrier(MPI_COMM_WORLD);
1221-
1222-
/* stop timer and print stats */
1223-
double end = MPI_Wtime();
1224-
if (mfu_debug_level >= MFU_LOG_VERBOSE) {
1225-
uint64_t min, max, sum;
1226-
MPI_Allreduce(&stats[ITEM_COUNT], &min, 1, MPI_UINT64_T, MPI_MIN, MPI_COMM_WORLD);
1227-
MPI_Allreduce(&stats[ITEM_COUNT], &max, 1, MPI_UINT64_T, MPI_MAX, MPI_COMM_WORLD);
1228-
MPI_Allreduce(&stats[ITEM_COUNT], &sum, 1, MPI_UINT64_T, MPI_SUM, MPI_COMM_WORLD);
1229-
double rate = 0.0;
1230-
if (end - start > 0.0) {
1231-
rate = (double)sum / (end - start);
1232-
}
1233-
double time_diff = end - start;
1234-
if (mfu_rank == 0) {
1235-
MFU_LOG(MFU_LOG_INFO, "level=%d min=%lu max=%lu sum=%lu rate=%f secs=%f",
1236-
(minlevel + level), (unsigned long)min, (unsigned long)max, (unsigned long)sum, rate, time_diff);
1237-
}
1238-
}
12391218
}
12401219

12411220
/* finalize our progress messages */

0 commit comments

Comments
 (0)