Skip to content

[shardformer] removed inplace tensor sharding #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

[shardformer] removed inplace tensor sharding #4018

merged 1 commit into from
Jun 16, 2023

Conversation

FrankLeeeee
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #4017

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR added non-inplace tensor sharding with DTensor.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee added enhancement New feature or request shardformer labels Jun 16, 2023
@FrankLeeeee FrankLeeeee linked an issue Jun 16, 2023 that may be closed by this pull request
[FEATURE]: Support Non-inplace Tensor Sharding #4017
Open
@FoolPlayer FoolPlayer merged commit c3791fa into hpcaitech:refactor/shardformer Jun 16, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/dtensor branch June 16, 2023 08:08
FrankLeeeee added a commit that referenced this pull request Jun 16, 2023
@FrankLeeeee
[shardformer] removed inplace tensor sharding (#4018)
26e2594
FrankLeeeee added a commit that referenced this pull request Jun 26, 2023
@FrankLeeeee
[shardformer] removed inplace tensor sharding (#4018)
eaa46d7
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Jul 3, 2023
@FrankLeeeee @flybird11111
[shardformer] removed inplace tensor sharding (hpcaitech#4018)
b827210
FrankLeeeee added a commit that referenced this pull request Jul 4, 2023
@FrankLeeeee
[shardformer] removed inplace tensor sharding (#4018)
45d9384
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
@FrankLeeeee @ver217
[shardformer] removed inplace tensor sharding (hpcaitech#4018)
4284830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoolPlayer FoolPlayer FoolPlayer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request shardformer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Support Non-inplace Tensor Sharding
2 participants
@FrankLeeeee @FoolPlayer