HPCC-33885 Ensure persistent pods handle logging config changes without restarts

Implement ability to change to table log format.
Add ability for on-the-fly logging configuration changes.
Validate on-the-fly logging configuration changes to prevent log format change.

Signed-off-by: Dave Streeter <[email protected]>

Author: streeterd

dali/base/sysinfologger.cpp

@@ -778,6 +778,10 @@ class DaliMsgLoggerHandler : public CSimpleInterfaceOf<ILogMsgHandler>
     {
         return 0;
     }
+    virtual LogHandlerFormat queryFormatType() const override
+    {
+         return LOGFORMAT_undefined;
+    };
 private:
     unsigned messageFields = MSGFIELD_all;
 };

helm/hpcc/templates/_helpers.tpl

@@ -1,7 +1,7 @@
 {{/*
 
 ---  DO NOT EDIT THIS FILE - all configuration of HPCC platform should be done via values.yaml ----
-  
+
 ##############################################################################
 
     HPCC SYSTEMS software Copyright (C) 2021 HPCC Systems®.
@@ -17,7 +17,7 @@
     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     See the License for the specific language governing permissions and
     limitations under the License.
-    
+
 ##############################################################################
 
 */}}
@@ -64,7 +64,7 @@ Translate a port list to a comma-separated list
   {{- $local := dict "first" true -}}
   {{- range $key, $value := . -}}{{- if not $local.first -}},{{- end -}}{{- $value -}}{{- $_ := set $local "first" false -}}{{- end -}}
  {{- else -}}
-  {{- . -}} 
+  {{- . -}}
  {{- end -}}
 {{- end -}}
 
@@ -877,7 +877,7 @@ Generates image information into env. variables used at runtime for runtime plat
 {{- end -}}
 
 {{/*
-Add image attributes for a component 
+Add image attributes for a component
 Pass in a dictionary with root, me and imagename defined
 */}}
 {{- define "hpcc.addImageAttrs" -}}
@@ -890,7 +890,7 @@ imagePullPolicy: {{ .root.Values.global.image.pullPolicy | default "IfNotPresent
 {{- end -}}
 
 {{/*
-Add image pull credentials for a component 
+Add image pull credentials for a component
 Pass in a dictionary with root and me defined
 */}}
 {{- define "hpcc.addImagePullSecrets" -}}
@@ -1237,7 +1237,7 @@ Generate instance queue names
 {{- range $.Values.roxie -}}
  {{- if not .disabled -}}
 - name: {{ .name }}
-  type: roxie 
+  type: roxie
   {{- if hasKey . "prefix" }}
   prefix: {{ .prefix }}
   {{- end }}
@@ -1660,12 +1660,12 @@ spec:
   loadBalancerSourceRanges:
   {{- if ne $lvars.type "LoadBalancer" -}}
    {{- $_ := fail (printf "loadBalanceSourceRanges invalid unless service type is LoadBalancer" ) -}}
-  {{- end -}} 
+  {{- end -}}
   {{- range $cidr := $lvars.loadBalancerSourceRanges }}
   - {{ $cidr }}
   {{- end }}
 {{ end }}
-{{- if $lvars.ingress }} 
+{{- if $lvars.ingress }}
 ---
 apiVersion: networking.k8s.io/v1
 kind: NetworkPolicy
@@ -1727,7 +1727,7 @@ dali data
 A template to generate the standard app.kubernetes.io labels and standard HPCC labels
 
 Pass in root, name, component, instance
-root name(k8s application name) component(component within the application, can be same as app) instance 
+root name(k8s application name) component(component within the application, can be same as app) instance
 
 https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
 ----------------------------+-------------------------------------------------------------+----------
@@ -2623,7 +2623,7 @@ globalExcludeList below is a hard-coded list of global keys to exclude.
 
 */}}
 {{- define "hpcc.getConfigSHA" }}
-{{- $globalExcludeList := list "~.*::replicas" "~.*::vaults" -}}
+{{- $globalExcludeList := list "~.*::logging" "~.*::replicas" "~.*::vaults" -}}
 {{- $globalExcludeSectionRegexList := list ".*-job.yaml$" -}}
 {{- $componentExcludeList := ternary (splitList "," (.excludeKeys | default "")) list (hasKey . "excludeKeys") -}}
 {{- $combinedExcludeKeyList := concat $globalExcludeList $componentExcludeList -}}
@@ -2803,7 +2803,7 @@ Pass in dict with .root, .me and .labels
   {{- $_ := set $lvars "egress" .me.egress -}}
  {{- end -}}
 {{- end -}}
-{{- if $lvars.egress }} 
+{{- if $lvars.egress }}
 apiVersion: networking.k8s.io/v1
 kind: NetworkPolicy
 metadata:
@@ -2921,7 +2921,7 @@ spec:
   minReplicas: {{ (hasKey .hpa "minReplicas") | ternary .hpa.minReplicas 1 }}
   maxReplicas: {{ .hpa.maxReplicas }}
    {{- if hasKey .hpa "behavior" }}
-  behavior: 
+  behavior:
     {{- if hasKey .hpa.behavior "scaleDown" }}
     scaleDown:
       {{- include "hpcc.addHPABehaviorScale" (dict "behaviorScale" .hpa.behavior.scaleDown) | nindent 6 }}