Skip to content

Commit af18f78

Browse files
committed
handle empty case in some metric tests
1 parent 99d36f2 commit af18f78

File tree

5 files changed

+12
-11
lines changed

5 files changed

+12
-11
lines changed
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
private
22
averageHierarchyHeightOf: aSLSystemTestObject
33

4-
^ ((aSLSystemTestObject rootClasses collect:
5-
[:class | class resultOf: #heightOfInheritanceTree: ]) sum) / (aSLSystemTestObject rootClasses size)
4+
^ (((aSLSystemTestObject rootClasses ifEmpty: [^ Float nan])
5+
collect: [:class | class resultOf: #heightOfInheritanceTree:]) sum)
6+
/ aSLSystemTestObject rootClasses size
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
private
22
averageNumberOfDerivedClassesOf: aSLSystemTestObject
33

4-
5-
^ ((aSLSystemTestObject allClasses collect:
6-
[:class | class testObject subclasses size]) sum ) / (aSLSystemTestObject resultOf: #classCount:)
4+
^ ((aSLSystemTestObject allClasses ifEmpty: [^ Float nan])
5+
collect: [:class | class testObject subclasses size]) sum
6+
/ (aSLSystemTestObject resultOf: #classCount:)

packages/SwaLint-PlugIns.package/SLCodingStylesPlugIn.class/instance/systemCALLS..st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
private
22
systemCALLS: aSLSystemTestObject
33

4-
^((aSLSystemTestObject allClasses collect:
4+
^(((aSLSystemTestObject allClasses ifEmpty: [^ Float nan]) collect:
55
[:class | (class methods ifEmpty: [{0}] ifNotEmpty: [(class methods collect:
66
[:method | (method resultOf: #methodCallers:) itemCount])])
77
sum ])

packages/SwaLint-PlugIns.package/SLCodingStylesPlugIn.class/instance/systemCYCLO..st

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
private
22
systemCYCLO: aSLSystemTestObject
33

4-
^((aSLSystemTestObject allClasses collect:
4+
^(((aSLSystemTestObject allClasses ifEmpty: [^ Float nan]) collect:
55
[:class | (class methods ifEmpty: [{0}] ifNotEmpty: [(class methods collect:
66
[:method | (method resultOf: #methodCYCLO:) result])])
77
sum ])

packages/SwaLint-PlugIns.package/SLCodingStylesPlugIn.class/methodProperties.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
"defaultCategory" : "AT 5/7/2008 21:30" },
66
"instance" : {
77
"averageHierarchyHeight:" : "ct 12/19/2024 20:25",
8-
"averageHierarchyHeightOf:" : "ct 12/19/2024 20:25",
8+
"averageHierarchyHeightOf:" : "ct 1/5/2025 03:43",
99
"averageNumberOfDerivedClasses:" : "NA 7/31/2015 19:27",
10-
"averageNumberOfDerivedClassesOf:" : "NA 7/30/2015 12:32",
10+
"averageNumberOfDerivedClassesOf:" : "ct 1/5/2025 03:44",
1111
"classNamespaceResult:" : "BD 6/29/2018 12:47",
1212
"collectNamespaces:" : "AT 5/27/2008 18:14",
1313
"commonStartOf:" : "BD 6/29/2018 12:16",
@@ -34,6 +34,6 @@
3434
"overviewPyramidMetric:" : "ct 12/20/2024 01:17",
3535
"printOn:" : "NH 6/24/2015 14:11",
3636
"qualityResult:" : "BD 7/4/2018 19:45",
37-
"systemCALLS:" : "SH 6/18/2015 11:54",
38-
"systemCYCLO:" : "SH 6/18/2015 11:49",
37+
"systemCALLS:" : "ct 1/5/2025 03:44",
38+
"systemCYCLO:" : "ct 1/5/2025 03:45",
3939
"systemFANOUT:" : "BD 7/25/2018 16:17" } }

0 commit comments

Comments
 (0)