Only ever match valid layouts in PIC guard

This avoids blowing inline cache limits unnecessarily.

Author: fniephaus

src/de.hpi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/model/AbstractPointersObject.java

@@ -137,6 +137,15 @@ public final ObjectLayout getLayout() {
         return layout;
     }
 
+    public final boolean matchesLayout(final ObjectLayout expectedLayout) {
+        if (!getLayout().isValid()) {
+            CompilerDirectives.transferToInterpreterAndInvalidate();
+            updateLayout();
+        }
+        assert layout.isValid() : "Should only ever match valid layout (invalid expectedLayout will be replaced in PIC)";
+        return layout == expectedLayout;
+    }
+
     public final void changeClassTo(final ClassObject newClass) {
         setSqueakClass(newClass);
         migrateToLayout(newClass.getLayout());

src/de.hpi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/model/layout/ObjectLayout.java

@@ -11,7 +11,6 @@
 import com.oracle.truffle.api.Assumption;
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
-import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.Truffle;
 import com.oracle.truffle.api.dsl.Idempotent;
 
@@ -207,7 +206,6 @@ public void invalidate() {
         isValidAssumption.invalidate("Layout no longer valid");
     }
 
-    @TruffleBoundary
     public boolean isValid() {
         return isValidAssumption.isValid();
     }

src/de.hpi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/LookupClassGuard.java

@@ -189,7 +189,7 @@ private AbstractPointersObjectGuard(final AbstractPointersObject receiver) {
 
         @Override
         public boolean check(final Object receiver) {
-            return receiver instanceof final AbstractPointersObject o && o.getLayout() == expectedLayout;
+            return receiver instanceof final AbstractPointersObject o && o.matchesLayout(expectedLayout);
         }
 
         @Override