Remove job_type property from azurerm_storage_mover_job_definition

Per reviewer feedback, the job_type feature should be separated into
its own PR. Remove the job_type property from the resource schema,
model, CRUD logic, tests, and documentation.

Author: hqhqhqhqhqhqhqhqhqhqhq

internal/services/storagemover/storage_mover_job_definition_resource.go

@@ -24,7 +24,6 @@ type StorageMoverJobDefinitionResourceModel struct {
 	SourceName            string                  `tfschema:"source_name"`
 	TargetName            string                  `tfschema:"target_name"`
 	CopyMode              jobdefinitions.CopyMode `tfschema:"copy_mode"`
-	JobType               string                  `tfschema:"job_type"`
 	SourceSubpath         string                  `tfschema:"source_sub_path"`
 	TargetSubpath         string                  `tfschema:"target_sub_path"`
 	AgentName             string                  `tfschema:"agent_name"`
@@ -89,17 +88,6 @@ func (r StorageMoverJobDefinitionResource) Arguments() map[string]*pluginsdk.Sch
 			}, false),
 		},
 
-		"job_type": {
-			Type:     pluginsdk.TypeString,
-			Optional: true,
-			ForceNew: true,
-			Default:  string(jobdefinitions.JobTypeOnPremToCloud),
-			ValidateFunc: validation.StringInSlice([]string{
-				string(jobdefinitions.JobTypeOnPremToCloud),
-				string(jobdefinitions.JobTypeCloudToCloud),
-			}, false),
-		},
-
 		"source_sub_path": {
 			Type:         pluginsdk.TypeString,
 			Optional:     true,
@@ -165,11 +153,6 @@ func (r StorageMoverJobDefinitionResource) Create() sdk.ResourceFunc {
 				},
 			}
 
-			if model.JobType != "" {
-				jobType := jobdefinitions.JobType(model.JobType)
-				properties.Properties.JobType = &jobType
-			}
-
 			if model.AgentName != "" {
 				properties.Properties.AgentName = &model.AgentName
 			}
@@ -283,10 +266,6 @@ func (r StorageMoverJobDefinitionResource) Read() sdk.ResourceFunc {
 
 				state.Description = pointer.From(v.Properties.Description)
 
-				if v.Properties.JobType != nil {
-					state.JobType = string(*v.Properties.JobType)
-				}
-
 				state.SourceName = v.Properties.SourceName
 
 				state.SourceSubpath = pointer.From(v.Properties.SourceSubpath)

internal/services/storagemover/storage_mover_job_definition_resource_test.go

@@ -82,21 +82,6 @@ func TestAccStorageMoverJobDefinition_update(t *testing.T) {
 	})
 }
 
-func TestAccStorageMoverJobDefinition_withJobType(t *testing.T) {
-	data := acceptance.BuildTestData(t, "azurerm_storage_mover_job_definition", "test")
-	r := StorageMoverJobDefinitionTestResource{}
-	data.ResourceTest(t, r, []acceptance.TestStep{
-		{
-			Config: r.withJobType(data),
-			Check: acceptance.ComposeTestCheckFunc(
-				check.That(data.ResourceName).ExistsInAzure(r),
-				check.That(data.ResourceName).Key("job_type").HasValue("CloudToCloud"),
-			),
-		},
-		data.ImportStep(),
-	})
-}
-
 func (r StorageMoverJobDefinitionTestResource) Exists(ctx context.Context, clients *clients.Client, state *pluginsdk.InstanceState) (*bool, error) {
 	id, err := jobdefinitions.ParseJobDefinitionID(state.ID)
 	if err != nil {
@@ -258,28 +243,3 @@ resource "azurerm_storage_mover_job_definition" "test" {
 }
 `, template, data.RandomInteger)
 }
-
-func (r StorageMoverJobDefinitionTestResource) withJobType(data acceptance.TestData) string {
-	template := r.template(data)
-	return fmt.Sprintf(`
-provider "azurerm" {
-  features {
-    resource_group {
-      prevent_deletion_if_contains_resources = false
-    }
-  }
-}
-
-%s
-
-resource "azurerm_storage_mover_job_definition" "test" {
-  name                     = "acctest-sjd-%[2]d"
-  storage_mover_project_id = azurerm_storage_mover_project.test.id
-  copy_mode                = "Additive"
-  job_type                 = "CloudToCloud"
-  source_name              = azurerm_storage_mover_source_endpoint.test.name
-  target_name              = azurerm_storage_mover_target_endpoint.test.name
-  description              = "CloudToCloud Job Definition"
-}
-`, template, data.RandomInteger)
-}

website/docs/r/storage_mover_job_definition.html.markdown

@@ -91,8 +91,6 @@ The following arguments are supported:
 
 * `copy_mode` - (Required) Specifies the strategy to use for copy. Possible values are `Additive` and `Mirror`.
 
-* `job_type` - (Optional) Specifies the type of job to run. Possible values are `OnPremToCloud` and `CloudToCloud`. Defaults to `OnPremToCloud`. Changing this forces a new resource to be created.
-
 * `source_sub_path` - (Optional) Specifies the sub path to use when reading from the Storage Mover Source Endpoint. Changing this forces a new resource to be created.
 
 * `target_sub_path` - (Optional) Specifies the sub path to use when writing to the Storage Mover Target Endpoint. Changing this forces a new resource to be created.