Add runtime check for modulo by zero (#1405)

* Add runtime check for modulo by zero

* Rerun regression tests

One of the tests now hits an MSVC error I've seen before, related to using std::source_location via module std import -- it doesn't manifest on any other compiler, or in MSVC using std headers. So the error is spurious, but I'm not able to debug it or find a workaround, and I don't want to record regression test failures just because of that use case where 'module std currently doesn't work.' So this commit also changes all -pure regression tests to use headers, not modules, at least for now until modules work better

---------

Co-authored-by: Herb Sutter <[email protected]>

Author: LT2H

regression-tests/test-results/mixed-initialization-safety-3.cpp

@@ -68,5 +68,5 @@ auto print_decorated(auto const& x) -> void{
 }
 
 #line 32 "mixed-initialization-safety-3.cpp2"
-[[nodiscard]] auto flip_a_coin() -> bool { return std::mt19937()() % 2 == 0;  }
+[[nodiscard]] auto flip_a_coin() -> bool { return std::mt19937()() % CPP2_ASSERT_NOT_ZERO_LITERAL(CPP2_TYPEOF(std::mt19937()()),2) == 0;  }
 

regression-tests/test-results/mixed-parameter-passing-with-forward.cpp

@@ -56,7 +56,7 @@ requires (std::is_convertible_v<CPP2_TYPEOF(e), std::add_const_t<std::string>&>)
     ++z;
     b += "plugh";
 
-    if (std::rand() % 2) {
+    if (std::rand() % CPP2_ASSERT_NOT_ZERO_LITERAL(CPP2_TYPEOF(std::rand()),2)) {
         ++z;
         copy_from(cpp2::move(b));// definite last use
     }
@@ -71,7 +71,7 @@ requires (std::is_convertible_v<CPP2_TYPEOF(e), std::add_const_t<std::string>&>)
 
     copy_from(z);
 
-    if (std::time(nullptr) % 2 == 0) {
+    if (std::time(nullptr) % CPP2_ASSERT_NOT_ZERO_LITERAL(CPP2_TYPEOF(std::time(nullptr)),2) == 0) {
         copy_from(cpp2::move(z));
     }
 

regression-tests/test-results/mixed-parameter-passing.cpp

@@ -69,7 +69,7 @@ auto parameter_styles(
     ++z;
     b += "plugh";
 
-    if (std::rand() % 2) {
+    if (std::rand() % CPP2_ASSERT_NOT_ZERO_LITERAL(CPP2_TYPEOF(std::rand()),2)) {
         ++z;
         copy_from(cpp2::move(b));// definite last use
     }
@@ -83,7 +83,7 @@ auto parameter_styles(
 
     copy_from(z);
 
-    if (std::time(nullptr) % 2 == 0) {
+    if (std::time(nullptr) % CPP2_ASSERT_NOT_ZERO_LITERAL(CPP2_TYPEOF(std::time(nullptr)),2) == 0) {
         copy_from(cpp2::move(z));
     }
 

regression-tests/test-results/pure2-assert-expected-not-null.cpp

@@ -1,5 +1,5 @@
 
-#define CPP2_IMPORT_STD          Yes
+#define CPP2_INCLUDE_STD         Yes
 
 //=== Cpp2 type declarations ====================================================
 

regression-tests/test-results/pure2-assert-optional-not-null.cpp

@@ -1,5 +1,5 @@
 
-#define CPP2_IMPORT_STD          Yes
+#define CPP2_INCLUDE_STD         Yes
 
 //=== Cpp2 type declarations ====================================================
 

regression-tests/test-results/pure2-assert-shared-ptr-not-null.cpp

@@ -1,5 +1,5 @@
 
-#define CPP2_IMPORT_STD          Yes
+#define CPP2_INCLUDE_STD         Yes
 
 //=== Cpp2 type declarations ====================================================
 

regression-tests/test-results/pure2-assert-unique-ptr-not-null.cpp

@@ -1,5 +1,5 @@
 
-#define CPP2_IMPORT_STD          Yes
+#define CPP2_INCLUDE_STD         Yes
 
 //=== Cpp2 type declarations ====================================================
 

regression-tests/test-results/pure2-bounds-safety-span.cpp

@@ -1,5 +1,5 @@
 
-#define CPP2_IMPORT_STD          Yes
+#define CPP2_INCLUDE_STD         Yes
 
 //=== Cpp2 type declarations ====================================================
 

regression-tests/test-results/pure2-break-continue.cpp

@@ -1,5 +1,5 @@
 
-#define CPP2_IMPORT_STD          Yes
+#define CPP2_INCLUDE_STD         Yes
 
 //=== Cpp2 type declarations ====================================================
 

regression-tests/test-results/pure2-bugfix-for-assign-expression-list.cpp

@@ -1,5 +1,5 @@
 
-#define CPP2_IMPORT_STD          Yes
+#define CPP2_INCLUDE_STD         Yes
 
 //=== Cpp2 type declarations ====================================================