Skip to content
This repository was archived by the owner on Apr 15, 2025. It is now read-only.
This repository was archived by the owner on Apr 15, 2025. It is now read-only.

Use better booleans for the proxy control variables #68

Open
@matyasselmeci

Description

@matyasselmeci

Just looking at whether *_DISABLE_HTTP_PROXY and *_DISABLE_PROXY_FALLBACK are set or unset is a pain to deal with, since it's sometimes hard to actually unset an environment variable (for example, in the docker command line).

IsProxyEnabled() and CanDisableProxy() should parse those environment variables as booleans using strconv.ParseBool(). Treat an invalid boolean (i.e. ParseBool returning an error) as false.

Update README.md to say that OSG_DISABLE_PROXY_FALLBACK must be set to true to be enabled.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions