Skip to content

Commit b5a4cfe

Browse files
Merge branch 'master' into hotgym-fix
2 parents 58c5cf6 + 438228a commit b5a4cfe

File tree

6 files changed

+42
-24
lines changed

6 files changed

+42
-24
lines changed

CHANGELOG.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# Changelog
22

3-
This file is no longer being updated.
4-
Instead see the [API_CHANGELOG](API_CHANGELOG.md).
3+
Also see [API_CHANGELOG](API_CHANGELOG.md).
4+
5+
## 2.0.0
6+
* changed repository name from nupic.core to htm.core
7+
* Added support for Visual Studio 2019
58

69
## 1.1.0
710

CommonCompilerConfig.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ set(COMMON_OS_LIBS)
154154

155155
if(MSVC)
156156
# MS Visual C
157-
# on Windows using Visual Studio 2015, 2017 https://docs.microsoft.com/en-us/cpp/build/reference/compiler-options-listed-by-category
157+
# on Windows using Visual Studio 2015, 2017, 2019 https://docs.microsoft.com/en-us/cpp/build/reference/compiler-options-listed-by-category
158158
# /permissive- forces standards behavior. See https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=vs-2017
159159
# /Zc:__cplusplus This is required to force MSVC to pay attention to the standard setting and sets __cplusplus.
160160
# NOTE: MSVC does not support C++11. But does support C++14 and C++17.

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Fork or download the HTM-Community htm.core repository from https://github.com/h
4646

4747
## Prerequisites
4848

49-
- [CMake](http://www.cmake.org/)
49+
- [CMake](http://www.cmake.org/) Version 3.8 (3.14 for Visual Studio 2019)
5050
- [Python](https://python.org/downloads/)
5151
- Version 3.4+
5252
- Version 2.7
@@ -125,10 +125,11 @@ make -j install
125125

126126
* This will not build the Python interface.
127127

128-
## Simple Build On Windows (MS Visual Studio 2017)
128+
## Simple Build On Windows (MS Visual Studio 2017 or 2019)
129129

130130
After downloading the repository, do the following:
131131

132+
* NOTE: Visual Studio 2019 requires CMake version 3.14 or higher.
132133
* CD to the top of repository.
133134
* Double click on startupMSVC.bat
134135
- This will setup the build, create the solution file (build/scripts/htm.cpp.sln), and start MS Visual Studio.

RELEASE.md

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
# Release Process
22

3-
1. Select a green build in Bamboo that has the changes that you want to release
4-
2. Ensure that this build has the correct version in the VERSION file
5-
3. Create a Bamboo release with version matching the VERSION file in the repo
6-
4. Deploy the release in Bamboo. This will:
7-
- Validate that the Bamboo release number matches the wheel versions.
8-
- Push the wheels to PyPI
9-
- Push the source archive to S3
10-
- Create a Github release
11-
- Tag the repo commit with the version
12-
- Bump the VERSION file to the next bugfix release number
3+
Not doing releases yet.
134

145
:-)

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.0.8.community0
1+
2.0.0

startupMSVC.bat

Lines changed: 31 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,30 @@
11
@echo off
2-
rem // Runs CMake to configure htm.core for Visual Studio 2017
2+
rem // Runs CMake to configure htm.core for Visual Studio 2017 and 2019
33
rem // Execute this file to start up CMake and configure Visual Studio.
44
rem //
55
rem // There is no need to use Developer Command Prompt for running CMake with
66
rem // Visual Studio generators, corresponding environment will be loaded automatically by CMake.
77
rem //
88
rem // Prerequisites:
99
rem //
10-
rem // Microsoft Visual Studio 2017 or newer (any flavor)
10+
rem // Microsoft Visual Studio 2017, 2019 or newer (any flavor)
1111
rem //
1212
rem // CMake: 3.7+ Download CMake from https://cmake.org/download/
13+
rem // NOTE: CMake 3.14+ is required for MSCV 2019
1314
rem //
1415
rem // Python 2.7 or 3.x Download from https://www.python.org/downloads/windows/ (optional)
1516
rem //
1617
rem //
1718
rem // This script will create a Vsual Studio solution file at build/scripts/htm_core.sln
1819
rem // Double click htm_core.sln to start up Visual Studio. Then perform a full build.
1920
rem //
20-
rem // Tricks for executing Visual Studio is Release or Build mode.
21+
rem // Note: if you were originally using this repository with VS 2017 and you now
22+
rem // want to use VS 2019, Do the following:
23+
rem // 1) delete the build folder in the repository. This will remove the .sln and other VS files.
24+
rem // 2) run startupMSVC.bat again. It will detect that VS 2019 is installed and configure for it but it will start VS 2017.
25+
rem // 3) after .sln is re-created in build/scripts/, right click, on the .sln file, select "open with", click "choose another app", select VS 2019
26+
rem //
27+
rem // Tricks for executing Visual Studio in Release or Build mode.
2128
rem // https://stackoverflow.com/questions/24460486/cmake-build-type-not-being-used-in-cmakelists-txt
2229

2330

@@ -58,20 +65,36 @@ if exist "htm_core.sln" (
5865
exit /B 0
5966
)
6067

61-
rem // Run CMake using the Visual Studio generator for VS 2017
62-
rem // -G "Visual Studio 15 2017 Win64" set the generator toolset to use. Could also set ARM rather than Win64.
68+
rem // Run CMake using the Visual Studio generator. The generator can be one of these.
69+
rem // cmake -G "Visual Studio 15 2017" -A x64
70+
rem // cmake -G "Visual Studio 16 2017" -A ARM
71+
rem //
72+
rem // cmake -G "Visual Studio 16 2019" -A x64
73+
rem // cmake -G "Visual Studio 16 2019" -A ARM64
74+
rem // NOTE: MSVC 2019 tool set generator requires CMake V3.14 or greater)
75+
rem //
76+
rem // arguments:
77+
rem // -G "Visual Studio 16 2019" Sets the generator toolset (compilers/linkers) to use.
78+
rem // -A x64 Sets the platform. Note that 64bit only supported.
6379
rem // -Thost=x64 Tell CMake to tell VS to use 64bit tools for compiler and linker
6480
rem // --config "Release" Start out in Release mode
6581
rem // -DCMAKE_CONFIGURATION_TYPES="Debug;Release" Specify the build types allowed.
6682
rem // ../.. set the source directory (top of repository)
6783

68-
rem // cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 --config "Release" -DCMAKE_CONFIGURATION_TYPES="Debug;Release" -DBINDING_BUILD=Python3 ../..
69-
cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 --config "Release" -DCMAKE_CONFIGURATION_TYPES="Debug;Release" ../..
84+
if exist "C:\Program Files (x86)\Microsoft Visual Studio\2019" (
85+
set GENERATOR="Visual Studio 16 2019"
86+
set PLATFORM=x64
87+
) else (
88+
set GENERATOR="Visual Studio 15 2017"
89+
set PLATFORM=x64
90+
)
91+
92+
cmake -G %GENERATOR% -A %PLATFORM% -Thost=x64 --config "Release" -DCMAKE_CONFIGURATION_TYPES="Debug;Release" ../..
7093

7194
if exist "htm_core.sln" (
72-
rem //cmake --build . --target install --config "Release"
7395
@echo " "
7496
@echo You can now start Visual Studio using solution file %HTM_BASE%\build\scripts\htm_core.sln
97+
@echo Dont forget to set your default Startup Project to unit_tests.
7598
@echo Press any key to start Visual Studio
7699
pause >nul
77100

0 commit comments

Comments
 (0)