Skip to content

Commit 8f51bc2

Browse files
authored
Apply suggestions from code review
Co-authored-by: Gil Desmarais <gildesmarais@users.noreply.github.com>
1 parent c5093da commit 8f51bc2

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

src/content/docs/ruby-gem/guides/capturing-feed-configs.mdx

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,22 +94,19 @@ Capture focuses on:
9494
- `channel.url` (and related channel defaults)
9595
- `selectors.items`
9696
- `selectors.title`
97-
- `selectors.link` (derived href selector)
97+
- `selectors.url` (derived href selector)
9898
- `selectors.description` when a distinct description root exists
9999

100-
Rename `selectors.link` to `selectors.url` before shipping. Item URLs must use the canonical `url` selector key for RSS `<link>` output.
101-
102100
It does not invent author, `published_at`, categories, or enclosure selectors. Add those manually when the page exposes them reliably.
103101

104102
Description is omitted when it would resolve to the invalid CSS selector `.` (item root equals description root).
105103

106104
## Recommended Follow-Up
107105

108-
1. Rename `selectors.link``selectors.url` if present
109-
2. Validate: `html2rss validate my-feed.yml`
110-
3. Render: `html2rss feed my-feed.yml`
111-
4. Tighten selectors, strategy, or `request.botasaurus` options if needed
112-
5. For Feed Directory contributions, add `directory.topics` (see [Creating Custom Feeds](/creating-custom-feeds/#sharing-your-config))
106+
1. Validate: `html2rss validate my-feed.yml`
107+
2. Render: `html2rss feed my-feed.yml`
108+
3. Tighten selectors, strategy, or `request.botasaurus` options if needed
109+
4. For Feed Directory contributions, add `directory.topics` (see [Creating Custom Feeds](/creating-custom-feeds/#sharing-your-config))
113110

114111
## Related
115112

0 commit comments

Comments
 (0)