Skip to content

Commit b699f2a

Browse files
steveyeggeoutdoorsea
authored andcommitted
fix(test): remove t.Parallel from tests that mutate globals (gt-qvx)
TestStampLoop_SelfStampFails and TestStampLoop_InvalidValence mutate package-level wlStamp* globals, making t.Parallel() unsafe. This was the remaining unmerged change from PR gastownhall#3213 by outdoorsea — the core daemon/dolt config.yaml changes were already landed. Co-Authored-By: outdoorsea <outdoorsea@users.noreply.github.com>
1 parent c2b7e6e commit b699f2a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

internal/cmd/wl_stamp_loop_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ func TestStampLoop_EndToEnd(t *testing.T) {
126126
}
127127

128128
// TestStampLoop_SelfStampFails verifies the yearbook rule (author != subject).
129+
// Not parallel: mutates package-level wlStamp* globals.
129130
func TestStampLoop_SelfStampFails(t *testing.T) {
130-
t.Parallel()
131131

132132
// Save/restore globals
133133
origQ, origR, origC := wlStampQuality, wlStampReliability, wlStampCreativity
@@ -172,8 +172,8 @@ func TestStampLoop_SelfStampFails(t *testing.T) {
172172
}
173173

174174
// TestStampLoop_InvalidValence verifies validation rejects out-of-range scores.
175+
// Not parallel: mutates package-level wlStamp* globals.
175176
func TestStampLoop_InvalidValence(t *testing.T) {
176-
t.Parallel()
177177
tests := []struct {
178178
name string
179179
quality float64

0 commit comments

Comments
 (0)