Skip to content

Commit 49a56ad

Browse files
committed
Changed scope for plainIP
Fixed failing tests Removed -Q option for showQR option
1 parent f5f25ef commit 49a56ad

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

bin/http-server

+17-17
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22

33
'use strict';
44

5-
var colors = require('colors/safe'),
6-
os = require('os'),
7-
httpServer = require('../lib/http-server'),
8-
portfinder = require('portfinder'),
9-
opener = require('opener'),
10-
fs = require('fs'),
11-
qrcode = require('qrcode-terminal');
12-
url = require('url');
5+
var colors = require('colors/safe'),
6+
os = require('os'),
7+
httpServer = require('../lib/http-server'),
8+
portfinder = require('portfinder'),
9+
opener = require('opener'),
10+
fs = require('fs'),
11+
qrcode = require('qrcode-terminal'),
12+
url = require('url');
1313
var argv = require('minimist')(process.argv.slice(2), {
1414
alias: {
1515
tls: 'ssl'
@@ -66,14 +66,13 @@ if (argv.h || argv.help) {
6666
}
6767

6868
var port = argv.p || argv.port || parseInt(process.env.PORT, 10),
69-
host = argv.a || '0.0.0.0',
70-
tls = argv.S || argv.tls,
71-
proxy = argv.P || argv.proxy,
72-
proxyOptions = argv['proxy-options'],
73-
utc = argv.U || argv.utc,
74-
version = argv.v || argv.version,
75-
logger;
76-
var plainIp = host;
69+
host = argv.a || '0.0.0.0',
70+
tls = argv.S || argv.tls,
71+
proxy = argv.P || argv.proxy,
72+
proxyOptions = argv['proxy-options'],
73+
utc = argv.U || argv.utc,
74+
version = argv.v || argv.version,
75+
logger;
7776

7877
var proxyOptionsBooleanProps = [
7978
'ws', 'xfwd', 'secure', 'toProxy', 'prependPath', 'ignorePath', 'changeOrigin',
@@ -154,7 +153,7 @@ function listen(port) {
154153
mimetypes: argv.mimetypes,
155154
username: argv.username || process.env.NODE_HTTP_SERVER_USERNAME,
156155
password: argv.password || process.env.NODE_HTTP_SERVER_PASSWORD,
157-
showQR: argv.Q || argv['qr-code']
156+
showQR: argv['qr-code']
158157
};
159158

160159
if (argv.cors) {
@@ -198,6 +197,7 @@ function listen(port) {
198197
var server = httpServer.createServer(options);
199198
server.listen(port, host, function () {
200199
var protocol = tls ? 'https://' : 'http://';
200+
var plainIp = protocol + host;
201201

202202
logger.info([
203203
colors.yellow('Starting up http-server, serving '),

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)