Remove warnings out of a few tests (chaos-polymtl#1601)

Description
There were still some warnings in some of the unit tests. I found them while compiling with warning as error.

Solution
Eliminates a bunch of warnings in the tests. Nothing special

Testing
All tests still pass, nothing has changed.

Documentation
Nothing to change here

Author: blaisb

CHANGELOG.md

@@ -9,6 +9,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
 - MINOR Add "max refinement level" parameter to "uniform" mesh adaptation method. Before, transient simulations would have meshes being refined indefinitely. This PR fixes this, adds an application test, and adds an assertion to avoid the use of uniform mesh adaptation with simplex meshes. [#1599](https://github.com/chaos-polymtl/lethe/pull/1599)
 
+### Fixed
+
+- MINOR Remove some compilation warning in some of the unit tests for mortar and core. [#1601](https://github.com/chaos-polymtl/lethe/pull/1601)
+
 ### [Master] - 2025-07-25
 
 ### Added

tests/core/lethe_grid_tool_mesh_cut_by_flat_2.cc

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright (c) 2021-2022, 2024 The Lethe Authors
+// SPDX-FileCopyrightText: Copyright (c) 2021-2025 The Lethe Authors
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception OR LGPL-2.1-or-later
 
 // Deal.II includes
@@ -40,7 +40,7 @@ test()
   DoFHandler<2>    dof_handler;
   DoFHandler<1, 2> flat_dof_handler;
 
-  FlatManifold<1, 2> flat_manifold();
+  FlatManifold<1, 2> flat_manifold;
 
 
   // Mesh

tests/mortar/manager_03.cc

@@ -217,7 +217,7 @@ main(int argc, char **argv)
       TrilinosWrappers::SparsityPattern dsp;
 
       dsp.reinit(dof_handler.locally_owned_dofs(),
-                 dof_handler.get_communicator());
+                 dof_handler.get_mpi_communicator());
 
       DoFTools::make_flux_sparsity_pattern(dof_handler, dsp, constraints);
 
@@ -367,7 +367,7 @@ main(int argc, char **argv)
       TrilinosWrappers::SparsityPattern dsp;
 
       dsp.reinit(dof_handler.locally_owned_dofs(),
-                 dof_handler.get_communicator());
+                 dof_handler.get_mpi_communicator());
 
       DoFTools::make_flux_sparsity_pattern(dof_handler, dsp, constraints);
       coupling_operator.add_sparsity_pattern_entries(dsp);

tests/mortar/manager_04.cc

@@ -190,7 +190,7 @@ main(int argc, char **argv)
       TrilinosWrappers::SparsityPattern dsp;
 
       dsp.reinit(dof_handler.locally_owned_dofs(),
-                 dof_handler.get_communicator());
+                 dof_handler.get_mpi_communicator());
 
       DoFTools::make_flux_sparsity_pattern(dof_handler, dsp, constraints);
 
@@ -326,7 +326,7 @@ main(int argc, char **argv)
       TrilinosWrappers::SparsityPattern dsp;
 
       dsp.reinit(dof_handler.locally_owned_dofs(),
-                 dof_handler.get_communicator());
+                 dof_handler.get_mpi_communicator());
 
       DoFTools::make_flux_sparsity_pattern(dof_handler, dsp, constraints);
       coupling_operator.add_sparsity_pattern_entries(dsp);

tests/mortar/plot_01.cc

@@ -47,15 +47,15 @@ output_mesh(const Triangulation<dim, spacedim> &tria,
   data_out.attach_triangulation(tria);
 
   Vector<double> vector(tria.n_active_cells());
-  vector = Utilities::MPI::this_mpi_process(tria.get_communicator());
+  vector = Utilities::MPI::this_mpi_process(tria.get_mpi_communicator());
   data_out.add_data_vector(vector, "ranks");
 
   data_out.build_patches(
     mapping,
     mapping_degree + 1,
     DataOut<dim, spacedim>::CurvedCellRegion::curved_inner_cells);
 
-  data_out.write_vtu_in_parallel(file_name, tria.get_communicator());
+  data_out.write_vtu_in_parallel(file_name, tria.get_mpi_communicator());
 }
 
 template <int dim, int spacedim>

tests/mortar/tests.h

@@ -610,7 +610,7 @@ class OperatorBase : public Subscriptor
         TrilinosWrappers::SparsityPattern dsp;
 
         dsp.reinit(dof_handler.locally_owned_dofs(),
-                   dof_handler.get_communicator());
+                   dof_handler.get_mpi_communicator());
 
         DoFTools::make_sparsity_pattern(dof_handler, dsp, *constraints);
 
@@ -1022,7 +1022,7 @@ class GeneralStokesOperator : public Subscriptor
         TrilinosWrappers::SparsityPattern dsp;
 
         dsp.reinit(dof_handler.locally_owned_dofs(),
-                   dof_handler.get_communicator());
+                   dof_handler.get_mpi_communicator());
 
         DoFTools::make_sparsity_pattern(dof_handler, dsp, *constraints);
 
@@ -1390,7 +1390,7 @@ class PoissonOperatorDG : public Subscriptor
         TrilinosWrappers::SparsityPattern dsp;
 
         dsp.reinit(dof_handler.locally_owned_dofs(),
-                   dof_handler.get_communicator());
+                   dof_handler.get_mpi_communicator());
 
         DoFTools::make_flux_sparsity_pattern(dof_handler, dsp, *constraints);
 
@@ -1823,7 +1823,7 @@ class GeneralStokesOperatorDG : public Subscriptor
         TrilinosWrappers::SparsityPattern dsp;
 
         dsp.reinit(dof_handler.locally_owned_dofs(),
-                   dof_handler.get_communicator());
+                   dof_handler.get_mpi_communicator());
 
         DoFTools::make_flux_sparsity_pattern(dof_handler, dsp, *constraints);
 

tests/solvers/physical_properties_manager_01.cc

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright (c) 2022-2023 The Lethe Authors
+// SPDX-FileCopyrightText: Copyright (c) 2022-2025 The Lethe Authors
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception OR LGPL-2.1-or-later
 
 /**
@@ -23,6 +23,7 @@ test()
   physical_properties.number_of_fluids                = 1;
   physical_properties.number_of_solids                = 0;
   physical_properties.number_of_material_interactions = 0;
+  physical_properties.reference_temperature           = 0;
   physical_properties.fluids.resize(1);
   physical_properties.fluids[0].density_model =
     Parameters::Material::DensityModel::constant;

tests/solvers/physical_properties_manager_02.cc

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright (c) 2023 The Lethe Authors
+// SPDX-FileCopyrightText: Copyright (c) 2023-2025 The Lethe Authors
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception OR LGPL-2.1-or-later
 
 /**
@@ -24,6 +24,7 @@ test()
   physical_properties.number_of_fluids                = 1;
   physical_properties.number_of_solids                = 1;
   physical_properties.number_of_material_interactions = 1;
+  physical_properties.reference_temperature           = 0;
 
 
   // Generate fluid properties

tests/solvers/physical_properties_manager_03.cc

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright (c) 2023 The Lethe Authors
+// SPDX-FileCopyrightText: Copyright (c) 2023-2025 The Lethe Authors
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception OR LGPL-2.1-or-later
 
 /**
@@ -25,6 +25,7 @@ test()
   physical_properties.number_of_fluids                = 2;
   physical_properties.number_of_solids                = 2;
   physical_properties.number_of_material_interactions = 5;
+  physical_properties.reference_temperature           = 0;
 
   physical_properties.fluids.resize(2);
   physical_properties.solids.resize(2);

tests/solvers/restart_01.cc

@@ -104,7 +104,7 @@ RestartNavierStokes<dim>::run()
   this->exact_solution   = new ExactSolutionMMS<dim>;
   this->forcing_function = std::make_shared<MMSSineForcingFunction<dim>>();
   Parameters::PhysicalProperties physical_properties;
-  physical_properties.fluids.emplace_back(Parameters::Material());
+  physical_properties.fluids.resize(1);
   physical_properties.number_of_fluids = 1;
   physical_properties.fluids[0].rheological_model =
     Parameters::Material::RheologicalModel::newtonian;