Skip to content

Commit ae8a546

Browse files
authored
canary: remove lark kanban reviewer hold (#1740)
1 parent ab5f64f commit ae8a546

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

examples/canary/premerge-validation-gate-smoke.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,17 @@ def assert_benchmark_sensitive_change_blocks_self_merge() -> None:
132132
assert payload["gate"]["self_merge_allowed"] is False, payload
133133

134134

135+
def assert_lark_kanban_change_keeps_surface_without_reviewer_hold() -> None:
136+
payload = build_premerge_validation_gate(
137+
changed_files=["loopx/cli_commands/lark_kanban.py"],
138+
execute=False,
139+
)
140+
classification = payload["classification"]
141+
assert "lark_kanban" in classification["surfaces"], payload
142+
assert classification["manual_holds"] == [], payload
143+
assert payload["gate"]["status"] == "preview_only", payload
144+
145+
135146
def assert_cli_json_preview() -> None:
136147
completed = subprocess.run(
137148
[
@@ -339,6 +350,7 @@ def main() -> None:
339350
assert_public_boundary_scan_executes_in_process()
340351
assert_changed_python_gets_compile_check()
341352
assert_benchmark_sensitive_change_blocks_self_merge()
353+
assert_lark_kanban_change_keeps_surface_without_reviewer_hold()
342354
assert_cli_json_preview()
343355
assert_cli_premerge_reports_progress_by_default()
344356
assert_no_changes_does_not_mask_direct_failures()

loopx/canary/premerge.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -287,12 +287,6 @@ def mark(surface: str, profile: str | None = None) -> None:
287287
)
288288
if any(_path_matches(path, LARK_KANBAN_TOKENS) for path in files):
289289
mark("lark_kanban")
290-
manual_holds.append(
291-
{
292-
"kind": "lark_kanban_reviewer",
293-
"reason": "Lark Kanban paths require ZaynJarvis review or explicit owner bypass",
294-
}
295-
)
296290
if python_files:
297291
mark("python")
298292
if not surfaces and files:

0 commit comments

Comments
 (0)