Skip to content

Commit f2c7ada

Browse files
committed
fix(pr-review): keep bootstrap packet compact
1 parent ffe9264 commit f2c7ada

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

examples/slash-command-catalog-smoke.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,12 @@ def main() -> int:
5050
assert pr_review["agent_contract"]["slash_prefix_dominates_intent"] is True, pr_review
5151
assert pr_review["agent_contract"]["stats_only_requires_explicit_opt_out"] is True, pr_review
5252
assert "agent_response_contract" in pr_review["agent_contract"]["authoritative_fields"], pr_review
53-
assert "agent_response_contract.review_execution_contract" in pr_review["agent_contract"]["authoritative_fields"], pr_review
5453
assert "agent_response_contract.explanation_depth_contract" in pr_review["agent_contract"]["authoritative_fields"], pr_review
5554
assert "review_groups.unmerged" in pr_review["agent_contract"]["authoritative_fields"], pr_review
5655
assert "review_groups.merged" in pr_review["agent_contract"]["authoritative_fields"], pr_review
5756
assert "agent_response_contract.required_final_sections" in pr_review["agent_contract"]["authoritative_fields"], pr_review
5857
assert pr_review["agent_contract"]["required_packet_fields_to_preserve"] == [
5958
"agent_response_contract",
60-
"agent_response_contract.review_execution_contract",
6159
"result_completeness",
6260
"review_groups",
6361
"pull_requests[].review_plan",
@@ -74,7 +72,7 @@ def main() -> int:
7472
"对主干的风险",
7573
"我的整体评价",
7674
], final_contract
77-
assert "per-section ranges" in final_contract["section_length_hint"], final_contract
75+
assert "review_template ranges" in final_contract["section_length_hint"], final_contract
7876
assert "may not know" in final_contract["reader_profile"], final_contract
7977
assert "remote head" in final_contract["freshness_policy"], final_contract
8078
assert "do not reconstruct" in pr_review["agent_contract"]["manual_gh_policy"], pr_review

loopx/slash_commands.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def build_slash_command_catalog(
123123
_command(
124124
command="/loopx-pr-review",
125125
scope="repo",
126-
intent="Run the pr-review CLI first, execute each capability-owned exact-head review plan, then render the verified result through the five-block template.",
126+
intent="Run pr-review, execute each exact-head review plan, then render verified evidence through the five-block template.",
127127
mutation_policy="read_only; does not comment, approve, merge, or spend quota",
128128
cli_reference=f"{cli_bin} pr-review [--repo owner/repo] [--state open|merged|all] [--since ISO]",
129129
agent_contract={
@@ -138,7 +138,6 @@ def build_slash_command_catalog(
138138
"stats_only_requires_explicit_opt_out": True,
139139
"authoritative_fields": [
140140
"agent_response_contract",
141-
"agent_response_contract.review_execution_contract",
142141
"agent_response_contract.explanation_depth_contract",
143142
"review_groups.unmerged",
144143
"review_groups.merged",
@@ -149,7 +148,6 @@ def build_slash_command_catalog(
149148
],
150149
"required_packet_fields_to_preserve": [
151150
"agent_response_contract",
152-
"agent_response_contract.review_execution_contract",
153151
"result_completeness",
154152
"review_groups",
155153
"pull_requests[].review_plan",
@@ -173,8 +171,8 @@ def build_slash_command_catalog(
173171
"对主干的风险",
174172
"我的整体评价",
175173
],
176-
"evidence_before_filling": "Execute each selected pull_requests[].review_plan against the shared review_execution_contract before filling the sections.",
177-
"section_length_hint": "Render verified evidence through the per-section ranges in pull_requests[].review_template without creating a competing host checklist.",
174+
"evidence_before_filling": "Execute each selected review_plan before filling the sections.",
175+
"section_length_hint": "Use review_template ranges to render verified evidence without a competing host checklist.",
178176
"reader_profile": "A technically curious reader who may not know the PR or subsystem.",
179177
"freshness_policy": "Record the remote head before review, recheck it before the verdict, and restart if it changed.",
180178
},
@@ -184,9 +182,7 @@ def build_slash_command_catalog(
184182
),
185183
"json_projection_policy": (
186184
"Do not pipe the first JSON packet to a summary-only projection. "
187-
"The agent must keep the capability review_execution_contract, "
188-
"review_groups, pull_requests[].review_plan, review_template, and "
189-
"evidence_commands "
185+
"Keep the response contract, review groups, plans, templates, and evidence commands "
190186
"visible before planning the final answer."
191187
),
192188
},

0 commit comments

Comments
 (0)