Skip to content

Commit 05188ec

Browse files
authored
[revert]revert changes for old version (#1014)
1 parent 2069022 commit 05188ec

6 files changed

Lines changed: 14 additions & 14 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
import spring-framework-bom. No need configure spring version. -->
4040
<spring-cloud.version>Greenwich.SR6</spring-cloud.version>
4141
<spring-boot.version>2.1.6.RELEASE</spring-boot.version>
42-
<servicecomb.version>2.7.4</servicecomb.version>
42+
<servicecomb.version>2.5.1</servicecomb.version>
4343
</properties>
4444

4545
<modules>

spring-cloud-huawei-common/src/main/java/com/huaweicloud/common/disovery/ServiceCenterUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public static AddressManager createAddressManager(DiscoveryBootstrapProperties d
4545
addresses = URLUtil.dealMultiUrl(discoveryProperties.getAddress());
4646
}
4747
LOGGER.info("initialize discovery server={}", addresses.toString());
48-
return new AddressManager("default", addresses, EventManager.getEventBus());
48+
return new AddressManager("default", addresses);
4949
}
5050

5151
// add other headers needed for registration by new ServiceCenterClient(...)

spring-cloud-huawei-common/src/main/java/com/huaweicloud/common/transport/DiscoveryBootstrapProperties.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public class DiscoveryBootstrapProperties {
4949
private boolean healthCheck = true;
5050

5151

52-
private int healthCheckInterval = 15;
52+
private int healthCheckInterval = 15000;
5353

5454
private int healthCheckRequestTimeout = 5000;
5555

@@ -70,10 +70,6 @@ public class DiscoveryBootstrapProperties {
7070

7171
private DataCenterInfo datacenter;
7272

73-
private static final int HEALTH_CHECK_MAX_INTERVAL = 600;
74-
75-
private static final int HEALTH_CHECK_MIN_INTERVAL = 1;
76-
7773
public String getServerAddress() {
7874
return serverAddress;
7975
}
@@ -175,9 +171,7 @@ public int getHealthCheckInterval() {
175171
}
176172

177173
public void setHealthCheckInterval(int healthCheckInterval) {
178-
if (healthCheckInterval <= HEALTH_CHECK_MAX_INTERVAL && healthCheckInterval >= HEALTH_CHECK_MIN_INTERVAL) {
179-
this.healthCheckInterval = healthCheckInterval;
180-
}
174+
this.healthCheckInterval = healthCheckInterval;
181175
}
182176

183177
public int getHealthCheckRequestTimeout() {

spring-cloud-huawei-config/src/main/java/com/huaweicloud/config/ConfigService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ private AddressManager configCenterAddressManager(ServiceCombConfigProperties co
103103
}
104104
LOGGER
105105
.info("initialize config server type={}, address={}.", configProperties.getServerType(), addresses.toString());
106-
return new AddressManager(serviceCombAkSkProperties.getProject(), addresses, EventManager.getEventBus());
106+
return new AddressManager(serviceCombAkSkProperties.getProject(), addresses);
107107
}
108108

109109
private HttpTransport createHttpTransport(boolean sslEnabled,
@@ -158,7 +158,7 @@ private void initServiceCenterConfig(ServiceCombConfigProperties configPropertie
158158
}
159159

160160
private KieAddressManager createKieAddressManager(List<String> addresses) {
161-
return new KieAddressManager(addresses, EventManager.getEventBus());
161+
return new KieAddressManager(addresses);
162162
}
163163

164164
private KieAddressManager configKieAddressManager(ServiceCombConfigProperties configProperties) {

spring-cloud-huawei-discovery/src/main/java/com/huaweicloud/servicecomb/discovery/registry/ServiceCombServiceRegistry.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
import java.util.List;
2121
import java.util.Map;
22-
import java.util.concurrent.TimeUnit;
2322
import java.util.stream.Collectors;
2423

2524
import org.apache.commons.lang3.StringUtils;
@@ -90,7 +89,7 @@ public void register(ServiceCombRegistration registration) {
9089
EventManager.getEventBus().register(this);
9190
serviceCenterRegistration.setMicroservice(registration.getMicroservice());
9291
serviceCenterRegistration.setMicroserviceInstance(registration.getMicroserviceInstance());
93-
serviceCenterRegistration.setHeartBeatInterval(TimeUnit.SECONDS.toMillis(discoveryBootstrapProperties.getHealthCheckInterval()));
92+
serviceCenterRegistration.setHeartBeatInterval(discoveryBootstrapProperties.getHealthCheckInterval());
9493
serviceCenterRegistration.setHeartBeatRequestTimeout(discoveryBootstrapProperties.getHealthCheckRequestTimeout());
9594

9695
addSchemaInfo(registration);

spring-cloud-huawei-governance/src/main/java/com/huaweicloud/governance/SpringCloudRetryExtension.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,11 @@ protected String extractStatusCode(Object response) {
4848
}
4949
return String.valueOf(status);
5050
}
51+
52+
@Override
53+
public Class<? extends Throwable>[] retryExceptions() {
54+
return new Class[] {
55+
HttpServerErrorException.class
56+
};
57+
}
5158
}

0 commit comments

Comments
 (0)