Skip to content

feat: allow passing of custom URLs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: allow passing of custom URLs #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions lib/strategy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ var OAuth2Strategy = require('passport-oauth2')
* https://orcid.org/content/register-client-application-0
*
* Options:
* - `sandbox` whether to use the ORCID sandbox API (for non-production environments)
* - `clientID` your ORCID application's client id
* - `clientSecret` your ORCID application's client secret
* - `callbackURL` URL to which ORCID will redirect the user after granting authorization
* - `sandbox` whether to use the ORCID sandbox API (for non-production environments)
* - `clientID` your ORCID application's client id
* - `clientSecret` your ORCID application's client secret
* - `callbackURL` URL to which ORCID will redirect the user after granting authorization
* - `authorizationURL` optional override for mocking service
* - `tokenURL` optional override for mocking service
*
* Example:
*
Expand All @@ -36,19 +38,21 @@ var OAuth2Strategy = require('passport-oauth2')
* @access public
*/
function Strategy (options, verify) {
options.scope = options.scope || '/authenticate'
const orcidHostname = options.sandbox ? 'sandbox.orcid.org' : 'orcid.org'
delete options.sandbox

if (options.sandbox) {
options.authorizationURL = 'https://sandbox.orcid.org/oauth/authorize'
options.tokenURL = 'https://sandbox.orcid.org/oauth/token'
} else {
options.authorizationURL = 'https://orcid.org/oauth/authorize'
options.tokenURL = 'https://orcid.org/oauth/token'
const defaults = {
scope: '/authenticate',
authorizationURL: `https://${orcidHostname}/oauth/authorize`,
tokenURL: `https://${orcidHostname}/oauth/token`,
}

delete options.sandbox
const mergedConfig = {
...defaults,
...options
}

OAuth2Strategy.call(this, options, verify)
OAuth2Strategy.call(this, mergedConfig, verify)
this.name = 'orcid'
}

Expand Down