Open
Description
Hello!
I have an issue with Google images search: because of the proxy I'm behind, the request sometimes timeout.
Though the timeout is nothing you can do about, the problem is that whenever the requests timeout, my hubot instance crashes.
The problem is hubot-google-images tries to get the statusCode field of an answer that doesn't contain any; I get the following answer:
{ [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
I cannot test it easily on my side (because I do not have full control of my development environment), but I think replacing line 84 of hubot-google-images.coffee
:
if res.statusCode is 403
by
if not ('statusCode' of res)
ms.send "Timeout :("
else if res.statusCode is 403
should fix this problem.
Metadata
Metadata
Assignees
Labels
No labels