fix: XampleTest script loading order (#1714)

* fix: scripts that use the Express router were not loaded in order in the XampleTest

* fix: Github actions message to use 20 instead of 18

Author: joeyguerra

.github/workflows/nodejs-macos.yml

@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
 
     steps:
     - uses: actions/checkout@v3

.github/workflows/nodejs-ubuntu.yml

@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, latest]
+        node-version: [20.x, latest]
 
     steps:
     - uses: actions/checkout@v3

.github/workflows/nodejs-windows.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: windows-latest
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
     steps:
     - uses: actions/checkout@v3
     - name: Use Node.js ${{ matrix.node-version }}

.github/workflows/pipeline.yml

@@ -20,7 +20,7 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 18.x
+          - 20.x
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -42,7 +42,7 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 18.x
+          - 20.x
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -64,7 +64,7 @@ jobs:
     strategy:
       matrix:
         node-version:
-          - 18.x
+          - 20.x
     steps:
       - name: Checkout
         uses: actions/checkout@v3

src/GenHubot.mjs

@@ -56,6 +56,9 @@ export default (robot) => {
   robot.respond(/helo room/, async res => {
     await res.send('Hello World!')
   })
+  robot.router.get('/helo', async (req, res) => {
+    res.send("HELO World! I'm Dumbotheelephant.")
+  })
 }`)
 
   File.writeFileSync('./tests/doubles/DummyAdapter.mjs', `
@@ -125,14 +128,21 @@ export default (robot) => {
   describe('Xample testing Hubot scripts', () => {
     let robot = null
     beforeEach(async () => {
-      robot = new Robot(dummyRobot, false, 'Dumbotheelephant')
+      robot = new Robot(dummyRobot, true, 'Dumbotheelephant')
       await robot.loadAdapter()
-      await robot.loadFile('./scripts', 'Xample.mjs')
       await robot.run()
+      await robot.loadFile('./scripts', 'Xample.mjs')
     })
     afterEach(() => {
       robot.shutdown()
     })
+    it('should handle /helo request', async () => {
+      const expected = "HELO World! I'm Dumbotheelephant."
+      const url = 'http://localhost:' + robot.server.address().port + '/helo'
+      const response = await fetch(url)
+      const actual = await response.text()
+      assert.strictEqual(actual, expected)
+      })
     it('should reply with expected message', async () => {
       const expected = "HELO World! I'm Dumbotheelephant."
       const user = robot.brain.userForId('test-user', { name: 'test user' })

src/Robot.mjs

@@ -470,12 +470,12 @@ class Robot {
   // returns nothing
   setupNullRouter () {
     const msg = 'A script has tried registering a HTTP route while the HTTP server is disabled with --disabled-httpd.'
-
+    const self = this
     this.router = {
-      get: () => this.logger.warning(msg),
-      post: () => this.logger.warning(msg),
-      put: () => this.logger.warning(msg),
-      delete: () => this.logger.warning(msg)
+      get: () => self.logger.info(msg),
+      post: () => self.logger.info(msg),
+      put: () => self.logger.info(msg),
+      delete: () => self.logger.info(msg)
     }
   }
 

test/XampleTest.mjs

@@ -13,14 +13,20 @@ import dummyRobot from './doubles/DummyAdapter.mjs'
 describe('Xample testing Hubot scripts', () => {
   let robot = null
   beforeEach(async () => {
-    robot = new Robot(dummyRobot, false, 'Dumbotheelephant')
+    robot = new Robot(dummyRobot, true, 'Dumbotheelephant')
     await robot.loadAdapter()
-    await robot.loadFile('./test/scripts', 'Xample.mjs')
     await robot.run()
+    await robot.loadFile('./test/scripts', 'Xample.mjs')
   })
   afterEach(() => {
     robot.shutdown()
   })
+  it('should handle /helo request', async () => {
+    const expected = "HELO World! I'm Dumbotheelephant."
+    const response = await fetch(`http://localhost:${robot.server.address().port}/helo`)
+    const actual = await response.text()
+    assert.strictEqual(actual, expected)
+  })
   it('should reply with expected message', async () => {
     const expected = 'HELO World! I\'m Dumbotheelephant.'
     const user = robot.brain.userForId('test-user', { name: 'test user' })

test/scripts/Xample.mjs

@@ -15,4 +15,7 @@ export default (robot) => {
   robot.respond(/helo (.*)/gi, async res => {
     await res.send(`Hello World! I'm ${robot.name}.`)
   })
+  robot.router.get('/helo', async (req, res) => {
+    res.send(`HELO World! I'm ${robot.name}.`)
+  })
 }