Skip to content

Commit 5a0ce04

Browse files
authored
feat: fix shell logger takeover when robot.logger is called before run (#1808)
* fix: robot.logger getting called prior to the Shell adapter loading
1 parent c9e78e0 commit 5a0ce04

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

test/Shell_test.mjs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ describe('Shell Adapter: Logger before adapter run', () => {
234234
const robot = new Robot('Shell', false, 'TestHubot')
235235
robot.stdin = new stream.Readable()
236236
robot.stdin._read = () => {}
237-
237+
238238
const originalLog = console.log
239239
const logMessages = []
240240
console.log = (...args) => {
@@ -245,20 +245,20 @@ describe('Shell Adapter: Logger before adapter run', () => {
245245
await assert.doesNotReject(async () => {
246246
// Before loadAdapter - uses default pino logger
247247
robot.logger.info('log before adapter load')
248-
248+
249249
await robot.loadAdapter()
250-
250+
251251
// After loadAdapter but before run - still uses pino logger (logger override happens in run())
252252
await robot.logger.info('log after load before run')
253-
253+
254254
await robot.run()
255-
255+
256256
// After run - uses Shell adapter's custom logger with formatted output
257257
await robot.logger.info('log after run')
258258
})
259-
259+
260260
// Verify that logging after run() uses the Shell adapter's custom formatted logger
261-
assert.ok(logMessages.some(msg => typeof msg === 'string' && msg.includes('[info]') && msg.includes('log after run')),
261+
assert.ok(logMessages.some(msg => typeof msg === 'string' && msg.includes('[info]') && msg.includes('log after run')),
262262
'Should use Shell adapter formatted logger after run()')
263263
} finally {
264264
console.log = originalLog

0 commit comments

Comments
 (0)