fix: Adapter name wasn't getting set correctly (#1798)

Author: joeyguerra

package.json

@@ -29,7 +29,7 @@
     "start": "bin/hubot",
     "gen": "bin/hubot --create myhubot",
     "pretest": "standard",
-    "test": "node --test",
+    "test": "node --test --test-timeout=20000",
     "test:smoke": "node src/**/*.js",
     "test:e2e": "bin/e2e-test.sh",
     "build:local": "npx @hubot-friends/sfab --folder ./docs --destination ./_site --verbose --serve /hubot/ --watch-path ./docs --scripts ./sfab-hooks",

src/Robot.mjs

@@ -501,8 +501,9 @@ class Robot {
   //
   // Returns nothing.
   async loadAdapter (adapterPath = null) {
-    if (this.adapter) {
+    if (this.adapter && this.adapter.use) {
       this.adapter = await this.adapter.use(this)
+      this.adapterName = this.adapter.name ?? this.adapter.constructor.name
       return
     }
     this.logger.debug(`Loading adapter ${adapterPath ?? 'from npmjs:'} ${this.adapterName}`)
@@ -521,6 +522,8 @@ class Robot {
       this.logger.error(`Cannot load adapter ${adapterPath ?? '[no path set]'} ${this.adapterName} - ${error}`)
       throw error
     }
+
+    this.adapterName = this.adapter.name ?? this.adapter.constructor.name
   }
 
   async requireAdapterFrom (adapaterPath) {

test/AdapterName_test.mjs

@@ -0,0 +1,36 @@
+import test from 'node:test'
+import assert from 'node:assert/strict'
+import { Robot, Adapter } from '../index.mjs'
+
+class InMemoryAdapter extends Adapter {
+}
+
+function getRobotWithAdapter (adapter) {
+  return new Robot({
+    async use (robot) {
+      adapter.robot = robot
+      return adapter
+    }
+  }, false, 'Hubot', 't-bot')
+}
+
+await test('Adapter Name', async (t) => {
+  await t.test('Adapter argument is an object with user function', async () => {
+    const adapter = new InMemoryAdapter()
+    const robot = getRobotWithAdapter(adapter)
+    await robot.loadAdapter()
+    assert.equal(robot.adapterName, 'InMemoryAdapter')
+  })
+
+  await t.test('Adapter argument is null', async () => {
+    const robot = new Robot(null, false, 'Hubot', 't-bot')
+    await robot.loadAdapter()
+    assert.equal(robot.adapterName, 'Shell')
+  })
+
+  await t.test('Adapter argument is a file path', async () => {
+    const robot = new Robot('../test/fixtures/MockAdapter.mjs', false, 'Hubot', 't-bot')
+    await robot.loadAdapter()
+    assert.equal(robot.adapterName, 'MockAdapter')
+  })
+})