Skip to content

Commit 9fc6539

Browse files
authored
Bump datasets for lance (#3294)
* bump datasets for lance * fix ci * again * again
1 parent 59e413f commit 9fc6539

File tree

16 files changed

+84
-42
lines changed

16 files changed

+84
-42
lines changed

DEVELOPER_GUIDE.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,25 @@ We don't use the package versions (in pyproject.toml files), no need to update t
305305

306306
All the contributions should go through a pull request. The pull requests must be "squashed" (ie: one commit per pull request).
307307

308+
## Update common dependencies
309+
310+
1. Go to `libs/libcommon`
311+
312+
2. Update dependencies in `pyproject.toml`.
313+
314+
3. Run a CLI on all projects that depend on libcommon:
315+
316+
```bash
317+
>>> poetry run cli_all_projects
318+
Multi CLI for projects: ...
319+
```
320+
321+
4. Then you can update all dependencies using
322+
323+
```bash
324+
>>> poetry lock
325+
```
326+
308327
## GitHub Actions
309328

310329
You can use [act](https://github.com/nektos/act) to test the GitHub Actions (see [.github/workflows/](.github/workflows/)) locally. It reduces the retroaction loop when working on the GitHub Actions, avoid polluting the branches with empty pushes only meant to trigger the CI, and allows to only run specific actions.

front/admin_ui/poetry.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jobs/cache_maintenance/poetry.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jobs/mongodb_migration/poetry.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libs/libapi/poetry.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libs/libcommon/poetry.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libs/libcommon/pyproject.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ python = "3.12.11"
1010
anyio = ">=3.4.0,<5"
1111
appdirs = "^1.4.4"
1212
cryptography = "^43.0.1"
13-
datasets = {git="https://github.com/huggingface/datasets.git", rev="f15c59970fef04e277a93b9c262ccdc7bd8038a4", extras = ["vision"]}
13+
datasets = {git="https://github.com/huggingface/datasets.git", rev="6db5f805a444a767726d58d5dd1cfaa25fc852c0", extras = ["vision"]}
1414
duckdb = "^1.2.2"
1515
environs = "^14.3.0"
1616
filelock = "^3.18.0"
@@ -73,6 +73,9 @@ validators = "^0.22.0"
7373
build-backend = "poetry.core.masonry.api"
7474
requires = ["poetry-core>=1.0.0"]
7575

76+
[tool.poetry.scripts]
77+
cli_all_projects = 'libcommon.scripts:cli_all_projects'
78+
7679
[tool.pytest.ini_options]
7780
filterwarnings = ["ignore::DeprecationWarning"]
7881
markers = [
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
import subprocess # nosec
2+
from pathlib import Path
3+
4+
5+
def cli_all_projects() -> None:
6+
all_projects_dir = Path(__file__).resolve().parents[-5]
7+
projects = [
8+
p
9+
for d in all_projects_dir.glob("*")
10+
if not d.name.startswith(".") and d.is_dir()
11+
for p in list(d.glob("*")) + [d]
12+
if (p / "pyproject.toml").exists()
13+
]
14+
projects.sort(key=lambda p: (p.name != "libcommon", "libs" not in p.parts, p))
15+
16+
print(f"Multi CLI for projects: {', '.join(str(project) for project in projects)}")
17+
while (command := input(">>> ")) not in ["exit", "exit()"]:
18+
for project in projects:
19+
print(f"cd {project}")
20+
subprocess.run(command.split(" "), cwd=project) # nosec

services/admin/poetry.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

services/api/poetry.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)