fix(map): fix progress bar exceeding total when load_from_cache_file=False#8170
Open
Nitin-Rajasekar wants to merge 2 commits intohuggingface:mainfrom
Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
load_from_cache_file=False, the progress bar inDataset.map()displayed a count that exceeded the dataset size (e.g. "800 examples" for a 400-row dataset).The bug:
pbar_initialwas computed usinglen(existing_cache_files), which counts cache files on disk regardless of whether they would be used. Withload_from_cache_file=False, those files exist but are ignored, yet the bar was initialized to the full dataset size as if all work was already done. The actual processing then added on top of that, pushing the counter past the total and causing tqdm to drop the percentage display entirely.Fix: use
num_shards - len(unprocessed_kwargs_per_job)instead, which is 0 whenload_from_cache_file=False, so the bar starts and counts correctly.Issue
Fixes #8167
Local verification
py -3.14 -m pytest tests/test_arrow_dataset.py -k "test_map_load_from_cache_file_false_progress_bar_starts_at_zero" -v2 passed
Risk
Low risk, a one-line change to how
pbar_initialis computed. No behaviour changes outside of the progress bar display.