-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flux Controlnet] Add control_guidance_start and control_guidance_end #9555
Comments
cc @asomoza |
Flux doesn't have the behavior of the the other models because we have the distilled version of the model, so this is just my speculation but, for the other inpainting/tile controlnets, you must have the Of course you can still play with the end result if you want a somewhat similar image, but that also can be achieved with plain img2img or you can do a mix of techniques to achieve a good results so having I'm not sure it'd help Flux to be good at inpainting though, so better if you keep you expectations low about this. Maybe you can test it with ComfyUI if it has it and post the results? |
In my case I'm not using inpainting conventionnaly to inpaint small areas and add or modify elements. (Like the dog on the bench example) I'm using it to modify 90% of the image, and preserve stuff like like outdoor view from an interior photo. I saw a picture of a ComfyUI workflow on Twitter showing start_percent: 0.000 and end_percent: 0.3000 which I assume is the equivalent to That's what led me to think those options might be helpful in my case.. |
you're correct, and yes, if you don't care about the final result and use the image as a guide, you can use the If you look at the image though, the controlnet isn't doing that much , you can probably achieve the same result with img2img and prompting. The only similarity with the control image is that there's a room, a window and a bed, it's missing a whole window and the bookshelf, and the shapes aren't even the same for the other ones. When you say 'preserve the outdoor view' of the scene, you mean 100%? If you lower the guidance end that won't be the result though. Just so you know, I'm not against this feature, just giving my opinion. If no one else from the community does it, I can allocate some time soon and implement this feature and test it. I use this option a lot with SDXL so I can see the benefit of it. |
alright, I added the labels and let's see if someone from the community is willing to do this, if not, when I have the time I'll implement it. |
Thanks a lot @asomoza 🙏 |
@asomoza I have added the control_guidance_start and end for all three flux controlnet files. |
It'd be nice to have
control_guidance_start
andcontrol_guidance_start
parameters added to flux Controlnet and Controlnet Inpainting pipelines.I'm currently making experiments with Flux Controlnet Inpainting but the results are poor even with a
controlnet_conditioning_scale
set to 0.6.I have to set
controlnet_conditioning_scale
to 0.4 to have non broken results.Maybe giving more control with the guidance start and end would help reach better results ?
The text was updated successfully, but these errors were encountered: