Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing deprecation msg for DynamicCache.seen_tokens - no cache_position in this class #32855

Closed
poedator opened this issue Aug 16, 2024 · 2 comments

Comments

@poedator
Copy link
Contributor

The message says "The seen_tokensattribute is deprecated and will be removed in v4.41. Use thecache_position model input instead." however there is no cache_position in this class (it is present in StaticCache). Perhaps there may be a clearer message.

code ref: https://github.com/huggingface/transformers/blame/7c1149120829eb58e42a1ba4dbd2a9fa98864707/src/transformers/cache_utils.py#L91

tagging @gante

@gante
Copy link
Member

gante commented Aug 16, 2024

@poedator thank you for opening this issue! 🤗

We're aware of it, and we're working on a pre-requisite task before tackling the current confusion around seen_tokens/get_seq_length. (In the long run, we don't want to use these functions, but rather use the explicit cache_positions all the time.)

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants