Multiple processor classes have input side-effects

[nph4rd]

Multiple processor classes mutate their text input when it's a list.

Example:

https://github.com/huggingface/transformers/blob/42c489f2ae738a3b690bb90aab274f02ff024795/src/transformers/models/qwen2_5_vl/processing_qwen2_5_vl.py#L156C21-L156C25

This results in unwanted downstream behaviour. For example, see this comment.

This behaviour shouldn't be handled neither by TRL nor vLLM, in my opinion.

Who can help?

@ArthurZucker @qubvel

Reproduction

The case of Qwen2.5-VL can be tested here.

Expected behavior

Ideally the function should have no input side-effects.

[nph4rd]

Opened #36866

I believe it addresses all processor classes with that pattern.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

[nph4rd]

@molbap / @ArthurZucker / @qubvel - any thoughts?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

[nph4rd]

Fixed in #37342