-
Notifications
You must be signed in to change notification settings - Fork 31.4k
Open
Labels
Description
Feature request
Remove the requests module in the setup.py
Lines 399 to 411 in dfe6e4c
| install_requires = [ | |
| deps["filelock"], # filesystem locks, e.g., to prevent parallel downloads | |
| deps["huggingface-hub"], | |
| deps["numpy"], | |
| deps["packaging"], # utilities from PyPA to e.g., compare versions | |
| deps["pyyaml"], # used for the model cards metadata | |
| deps["regex"], # for OpenAI GPT | |
| deps["requests"], # for downloading models over HTTPS | |
| deps["tokenizers"], | |
| deps["typer-slim"], # CLI utilities. In practice, already a dependency of huggingface_hub | |
| deps["safetensors"], | |
| deps["tqdm"], # progress bars in model download and training scripts | |
| ] |
Motivation
After #40889, Transformers had turned to httpx for core logic about network, so the requests should be depreciated.
Your contribution
Remove it from install_requires and clean up the left requests calling in core logic.