fix(blackfriday): codeblock breaks due extensions conflict

hugmouse · hugmouse · commit b43857510c72 · 2025-07-25T17:16:29.000+02:00
Bisecting this wasn't fun. So, the issue is that if you use any extensions after blackfriday.CommonExtensions it breaks codeblocks.

Additionally, I couldn't verify that footnotes or title block actually work, so those extensions are now disabled.
diff --git a/syntax/renderers/customBlackfriday/convert_blackfriday.go b/syntax/renderers/customBlackfriday/convert_blackfriday.go
@@ -97,9 +97,6 @@ func (b *BlackfridayRenderer) Convert(gmiContent string, wrap bool) string {
 		[]byte(input),
 		blackfriday.WithRenderer(proxy),
 		blackfriday.WithExtensions(blackfriday.CommonExtensions),
-		blackfriday.WithExtensions(blackfriday.HeadingIDs),
-		blackfriday.WithExtensions(blackfriday.Footnotes),
-		blackfriday.WithExtensions(blackfriday.Titleblock),
 	)
 	safe := bluemonday.UGCPolicy().SanitizeBytes(unsafe)
 

Original file line number	Diff line number	Diff line change
`@@ -97,9 +97,6 @@ func (b *BlackfridayRenderer) Convert(gmiContent string, wrap bool) string {`
`97`	`97`	`[]byte(input),`
`98`	`98`	`blackfriday.WithRenderer(proxy),`
`99`	`99`	`blackfriday.WithExtensions(blackfriday.CommonExtensions),`
`100`		`- blackfriday.WithExtensions(blackfriday.HeadingIDs),`
`101`		`- blackfriday.WithExtensions(blackfriday.Footnotes),`
`102`		`- blackfriday.WithExtensions(blackfriday.Titleblock),`
`103`	`100`	`)`
`104`	`101`	`safe := bluemonday.UGCPolicy().SanitizeBytes(unsafe)`
`105`	`102`