fix: refine TypeScript error handling and update test cases across multiple packages

Author: hugomrdias

packages/iso-base/test/basex.test.js

@@ -576,22 +576,22 @@ describe('basex', () => {
       const description = fixture.description
       const alphabet = alphabets[fixture.alphabet] ?? fixture.alphabet
 
-      if (fixture.string !== undefined) {
-        it(`decode should throw: ${description}`, () => {
-          const codec = base(alphabet)
+      if (fixture.string === undefined) {
+        // Alphabet validation error
+        it(`should throw on invalid alphabet: ${description}`, () => {
           assert.throws(
-            () => codec.decode(/** @type {string} */ (fixture.string)),
+            () => base(alphabet),
             (err) => {
               const regex = new RegExp(fixture.exception)
               return regex.test(/** @type {Error} */ (err).toString())
             }
           )
         })
       } else {
-        // Alphabet validation error
-        it(`should throw on invalid alphabet: ${description}`, () => {
+        it(`decode should throw: ${description}`, () => {
+          const codec = base(alphabet)
           assert.throws(
-            () => base(alphabet),
+            () => codec.decode(/** @type {string} */ (fixture.string)),
             (err) => {
               const regex = new RegExp(fixture.exception)
               return regex.test(/** @type {Error} */ (err).toString())

packages/iso-passkeys/src/cose.js

@@ -70,18 +70,18 @@ export function getCoseKeyType(key) {
  * @param {COSEALG} alg
  */
 export function mapCoseAlgToWebCryptoAlg(alg) {
-  // @ts-ignore
+  // @ts-expect-error
   if ([COSEALG_MAP.RS1].includes(alg)) {
     return 'SHA-1'
   }
   if (
-    // @ts-ignore
+    // @ts-expect-error
     [COSEALG_MAP.ES256, COSEALG_MAP.PS256, COSEALG_MAP.RS256].includes(alg)
   ) {
     return 'SHA-256'
   }
   if (
-    // @ts-ignore
+    // @ts-expect-error
     [COSEALG_MAP.ES384, COSEALG_MAP.PS384, COSEALG_MAP.RS384].includes(alg)
   ) {
     return 'SHA-384'
@@ -92,7 +92,7 @@ export function mapCoseAlgToWebCryptoAlg(alg) {
       COSEALG_MAP.PS512,
       COSEALG_MAP.RS512,
       COSEALG_MAP.EdDSA,
-      // @ts-ignore
+      // @ts-expect-error
     ].includes(alg)
   ) {
     return 'SHA-512'

packages/iso-passkeys/tsconfig.json

@@ -2,7 +2,8 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "emitDeclarationOnly": true,
-    "outDir": "dist"
+    "outDir": "dist",
+    "erasableSyntaxOnly": false
   },
   "references": [
     {

packages/iso-ucan/src/utils.js

@@ -42,7 +42,7 @@ export function nowInSeconds() {
 export async function cid(envelope) {
   const bytes = Envelope.encode({
     signature: envelope.signature,
-    // @ts-ignore
+    // @ts-expect-error
     signaturePayload: signaturePayload(envelope),
   })
   const hash = await sha256.digest(bytes)
@@ -333,7 +333,7 @@ export const selector = z.union([
 export const statement =
   /** @type {typeof z.lazy<z.ZodType<import('../src/types.js').Statement<unknown>>>} */ (
     z.lazy
-    // @ts-ignore
+    // @ts-expect-error
   )(() => {
     return z.union([
       z.tuple([

packages/iso-ucan/test/policy.test.ts

@@ -1,7 +1,6 @@
 import { assert, suite } from 'playwright-test/taps'
 import { validate } from '../src/policy.js'
 import type { Policy } from '../src/types.js'
-// @ts-ignore
 import fixtures from './fixtures/policy.json' with { type: 'json' }
 
 const policy = suite('policy')

packages/iso-ucan/tsconfig.json

@@ -18,7 +18,7 @@
       "path": "../iso-kv"
     }
   ],
-  "include": ["src", "scripts", "package.json", "test"],
+  "include": ["src", "scripts", "package.json", "test", "test/**/*.json"],
   "exclude": ["node_modules", "dist", "out"],
   "typedocOptions": {
     "entryPointStrategy": "resolve",

packages/iso-web/src/env.js

@@ -10,7 +10,7 @@ function isElectron() {
   if (
     typeof window !== 'undefined' &&
     typeof window.process === 'object' &&
-    // @ts-ignore
+    // @ts-expect-error
     window.process.type === 'renderer'
   ) {
     return true
@@ -56,12 +56,12 @@ export const IS_NODE =
   process.release.name === 'node' &&
   !IS_ELECTRON
 export const IS_WEBWORKER =
-  // @ts-ignore - we either ignore worker scope or dom scope
+  // @ts-expect-error - we either ignore worker scope or dom scope
   typeof importScripts === 'function' &&
   typeof globalThis !== 'undefined' &&
-  // @ts-ignore - we either ignore worker scope or dom scope
+  // @ts-expect-error - we either ignore worker scope or dom scope
   typeof WorkerGlobalScope !== 'undefined' &&
-  // @ts-ignore - we either ignore worker scope or dom scope
+  // @ts-expect-error - we either ignore worker scope or dom scope
   // eslint-disable-next-line no-undef
   globalThis instanceof WorkerGlobalScope
 export const IS_TEST =

packages/iso-web/src/http.js

@@ -207,7 +207,7 @@ export async function request(resource, options = {}) {
   }
 
   const timeoutSignal =
-    timeout !== false ? AbortSignal.timeout(timeout) : undefined
+    timeout === false ? undefined : AbortSignal.timeout(timeout)
   const combinedSignals = anySignal([signal, timeoutSignal])
 
   const _headers = new Headers(headers)

packages/iso-web/test/request.test.js

@@ -105,7 +105,6 @@ test('should retry with on response hook', async () => {
 test('should post json', async () => {
   server.use(
     http.post('https://local.dev/post', async ({ request }) => {
-      // @ts-ignore
       return Response.json(await request.json(), { status: 200 })
     })
   )
@@ -159,7 +158,6 @@ test('should request 500 with json body', async () => {
   server.use(
     http.get('https://local.dev/error-json', ({ request }) => {
       const params = Object.fromEntries(new URL(request.url).searchParams)
-      // @ts-ignore
       return HttpResponse.json(
         { error: 'error' },
         { status: Number(params.status) }

packages/iso-web/test/signals.test.js

@@ -20,7 +20,7 @@ test('should abort from any signal', () => {
 test('should ignore non signal', () => {
   const controllers = Array.from({ length: 5 }).map(() => new AbortController())
   const signals = controllers.map((c) => c.signal)
-  // @ts-ignore
+  // @ts-expect-error
   const signal = anySignal([...signals, { reason: 'test' }])
 
   assert.equal(signal.aborted, false)