fix(sort-imports): add submodule imports as internal patterns

Author: hugop95

docs/content/rules/sort-imports.mdx

@@ -261,7 +261,7 @@ Controls whether sorting should be done using the path of the import or its firs
 
 ### internalPattern
 
-<sub>default: `['^~/.+', '^@/.+']`</sub>
+<sub>default: `['^~/.+', '^@/.+', '^#.+']`</sub>
 
 Specifies a pattern for identifying internal imports. This is useful for distinguishing your own modules from external dependencies.
 
@@ -748,7 +748,7 @@ Specifies whether to use a new experimental dependency detection logic, with red
                   ignoreCase: true,
                   specialCharacters: 'keep',
                   sortBy: 'path',
-                  internalPattern: ['^~/.+', '^@/.+'],
+                  internalPattern: ['^~/.+', '^@/.+', '^#.+'],
                   partitionByComment: false,
                   partitionByNewLine: false,
                   newlinesBetween: 1,
@@ -793,7 +793,7 @@ Specifies whether to use a new experimental dependency detection logic, with red
                 ignoreCase: true,
                 specialCharacters: 'keep',
                 sortBy: 'path',
-                internalPattern: ['^~/.+', '^@/.+'],
+                internalPattern: ['^~/.+', '^@/.+', '^#.+'],
                 partitionByComment: false,
                 partitionByNewLine: false,
                 newlinesBetween: 1,

rules/sort-imports.ts

@@ -101,8 +101,8 @@ let defaultOptions: Required<Options[number]> = {
     'ts-equals-import',
     'unknown',
   ],
+  internalPattern: ['^~/.+', '^@/.+', '^#.+'],
   useExperimentalDependencyDetection: true,
-  internalPattern: ['^~/.+', '^@/.+'],
   fallbackSort: { type: 'unsorted' },
   partitionByComment: false,
   partitionByNewLine: false,

test/rules/sort-imports.test.ts

@@ -602,7 +602,7 @@ describe('sort-imports', () => {
       })
     })
 
-    it('handles hash symbol in internal patterns correctly', async () => {
+    it('marks submodule imports as internal by default', async () => {
       await valid({
         code: dedent`
           import type { T } from 'a'
@@ -616,12 +616,7 @@ describe('sort-imports', () => {
 
           import { d } from '../d'
         `,
-        options: [
-          {
-            ...options,
-            internalPattern: ['#.+'],
-          },
-        ],
+        options: [options],
       })
 
       await invalid({
@@ -658,12 +653,7 @@ describe('sort-imports', () => {
 
           import { d } from '../d'
         `,
-        options: [
-          {
-            ...options,
-            internalPattern: ['#.+'],
-          },
-        ],
+        options: [options],
       })
     })
 
@@ -4222,7 +4212,7 @@ describe('sort-imports', () => {
       })
     })
 
-    it('handles hash symbol in internal patterns correctly', async () => {
+    it('marks submodule imports as internal by default', async () => {
       await valid({
         code: dedent`
           import type { T } from 'a'
@@ -4236,12 +4226,7 @@ describe('sort-imports', () => {
 
           import { d } from '../d'
         `,
-        options: [
-          {
-            ...options,
-            internalPattern: ['#.+'],
-          },
-        ],
+        options: [options],
       })
 
       await invalid({
@@ -4278,12 +4263,7 @@ describe('sort-imports', () => {
 
           import { d } from '../d'
         `,
-        options: [
-          {
-            ...options,
-            internalPattern: ['#.+'],
-          },
-        ],
+        options: [options],
       })
     })
 
@@ -7642,7 +7622,7 @@ describe('sort-imports', () => {
       })
     })
 
-    it('handles hash symbol in internal patterns correctly', async () => {
+    it('marks submodule imports as internal by default', async () => {
       await valid({
         code: dedent`
           import type { T } from 'a'
@@ -7656,12 +7636,7 @@ describe('sort-imports', () => {
 
           import { d } from '../d'
         `,
-        options: [
-          {
-            ...options,
-            internalPattern: ['#.+'],
-          },
-        ],
+        options: [options],
       })
 
       await invalid({
@@ -7698,12 +7673,7 @@ describe('sort-imports', () => {
 
           import { d } from '../d'
         `,
-        options: [
-          {
-            ...options,
-            internalPattern: ['#.+'],
-          },
-        ],
+        options: [options],
       })
     })