Skip to content

Authenticate confidential clients on the authorization_code grant #3

Description

@roborourke

Endpoints\Token::exchange_token() performs no client authentication at all on the authorization_code grant — anyone holding a code and a client_id can redeem it, confidential clients included. This is the plugin's largest gap; PKCE (#1) only covers clients that opt in and is not a substitute for client authentication (RFC 6749 §4.1.3).

Client::get_type() returns 'public' or 'private' but nothing branches on it yet, and legacy/test data can have '' or other values — that needs normalizing before it can gate anything.

Mirrors upstream WP-API#36.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions