Possible bug when dropdown menus close

[brandonp-ais]

Hi, didn't want to raise a bug until I was sure.

Variously, our dropdowns have started throwing an error when an item is selected and the dropdown closes.

onCloseAutoFocus.current is not a function

Looking at the code from console output, the crash happens here:

bits-ui/packages/bits-ui/src/lib/bits/utilities/focus-scope/use-focus-scope.svelte.ts

Line 199 in e46355b

onCloseAutoFocus.current(destroyEvent);

I am guessing from where the handleClose function is called that the param to that function is expected to sometimes be null, but .current is called on it regardless.

I'm very unfamiliar with the code base and so could be completely off. I'm not yet able to reproduce, but I will try to make one if you need.

Thanks!

[brandonp-ais]

Perhaps interesting update

I still have not managed to make a repo I can share, BUT, I've confirmed that it is a specific version of svelte where the bug occurs: 5.23.0!

Release 5.23.0

When i downgrade my project before that, no problems.

But upgrading to that version+ and get the issue.

[huntabyte]

On the latest version of Svelte are you still able to reproduce? I'm not able to reproduce in my local environment

[brandonp-ais]

@huntabyte

I've confirmed that removing svelte 4 compatibility fixed the problem in our large sveltekit application

#1302 (reply in thread)

The lastest versions of svelte and bits-ui work with our app if that compiler option is not there, and breaks in the same way still if it is there .

So the reproduction is just adding that option to svelte.config.js

https://stackblitz.com/edit/egxubfvg?file=svelte.config.js

Thanks so much!

[neo-noire]

I got the same error after updating svelte to 5.25.5.
When I'm closing combobox dropdown, got :
Uncaught TypeError: onCloseAutoFocus.current is not a function .
After that dropdown is no longer opened.

[huntabyte]

Are you running the latest version of bits as well?

[huntabyte]

If so please provide a reproduction via stackblitz (you can click the "open in stackblitz" on any demo on bits-ui.com) and I'll look.

[Wiblz]

Having the same issue when closing a Dialog. svelte 5.25.3, bits-ui 1.3.16

[Wiblz]

What about locally? Mind sharing snippets of your code, or maybe a sample repository?

Oh, I just got it. Using svelte 5 in the compatibility mode breaks it. You can check out the stackblitz now.

[shyakadavis]

Hmm…, @Wiblz quick question:

Why do you have this in your svelte.config.js? Cause removing it fixes the issue 🤷
Are you on a Svelte 4 codebase and trying to use Svelte 5 APIs (or vice versa)?

compilerOptions: {
    compatibility: {
      componentApi: 4,
    },
  },

[Wiblz]

@shyakadavis Some of the dependencies are still on svelte 4, comp mode is the only way to make it work.

[LunaeSomnia]

I'm having the issue without using the compatibility mode. I'll see if I can reproduce it locally. Code available here, and stackblitz here.

EDIT: In my case, the problem is that I'm using custom elements in my svelte configuration:

compilerOptions: {
  customElement: true,
},

[huntabyte]

If someone wants to look into this and add undefined checks (in places they really shouldn't need to be), then I will consider merging a PR to support compat mode