Skip to content

Commit ef901b6

Browse files
[DEV-9027] change x-forwarded-for header ordering (#31)
1 parent dfa9d7a commit ef901b6

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

Diff for: debian/changelog

+6
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
python-tortik (0.2.10) unstable; urgency=low
2+
3+
* сhanged x-forwarded-for headers ordering
4+
5+
-- Vitaly Glibin <[email protected]> Fri, 29 Nov 2022 09:00:00 +0300
6+
17
python-tortik (0.2.9) unstable; urgency=low
28

39
* remove redundant logs

Diff for: tortik/util/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def make_list(val):
5050

5151
def real_ip(request):
5252
# split is for X-Forwarded-For header that can consist of many IPs: X-Forwarded-For: client, proxy1, proxy2
53-
return (request.headers.get('X-Real-Ip', None) or request.headers.get('X-Forwarded-For', None) or
53+
return (request.headers.get('X-Forwarded-For', None) or request.headers.get('X-Real-Ip', None) or
5454
request.remote_ip or '127.0.0.1').split(',')[0]
5555

5656

Diff for: tortik/version.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ def __parse_version_from_changelog():
1313
except (IOError, AttributeError):
1414
return None
1515

16-
version = __parse_version_from_changelog() or '0.2.9'
16+
version = __parse_version_from_changelog() or '0.2.10'

Diff for: tortik_tests/util_test.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,14 @@ def test_real_ip(self):
146146
request = Request()
147147
request.headers = {'X-Real-Ip': '8.8.8.8', 'X-Forwarded-For': '10.0.0.1'}
148148

149-
self.assertEqual('8.8.8.8', real_ip(request))
149+
self.assertEqual('10.0.0.1', real_ip(request))
150150

151151
request = Request()
152152
request.headers = {'X-Forwarded-For': '10.0.0.1, 127.0.0.1'}
153153

154154
self.assertEqual('10.0.0.1', real_ip(request))
155+
156+
request = Request()
157+
request.headers = {'X-Real-Ip': '8.8.8.8'}
158+
159+
self.assertEqual('8.8.8.8', real_ip(request))

0 commit comments

Comments
 (0)