Skip to content

Commit 6fcad88

Browse files
Improved class inheritance and type annotations
1 parent 7e6adbf commit 6fcad88

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

yatq/worker/factory/base.py

+3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88

99

1010
class BaseJobFactory(ABC):
11+
def __init__(self, **kwargs):
12+
super().__init__()
13+
1114
@abstractmethod
1215
def create_job(self, task: "Task") -> BaseJob: # pragma: no cover
1316
...

yatq/worker/factory/simple.py

+2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ class SimpleJobFactory(BaseJobFactory, Generic[T_SimpleJobClass]):
1414
def __init__(
1515
self,
1616
handlers: Dict[str, Type[T_SimpleJobClass]],
17+
**kwargs,
1718
):
19+
super().__init__(**kwargs)
1820
self.handlers = handlers
1921

2022
def create_job(self, task: "Task") -> T_SimpleJobClass:

yatq/worker/worker_settings.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
import aioredis
55

6+
from yatq.worker.factory.base import BaseJobFactory
67
from yatq.worker.factory.simple import SimpleJobFactory
78
from yatq.worker.job.base import BaseJob
89

@@ -11,7 +12,7 @@
1112

1213
class WorkerSettings:
1314

14-
factory_cls: Type[SimpleJobFactory] = SimpleJobFactory
15+
factory_cls: Type[BaseJobFactory] = SimpleJobFactory
1516
factory_kwargs: Optional[Dict] = None
1617

1718
queue_namespace: Optional[str] = None

0 commit comments

Comments
 (0)