Commit 86b31ec
committed
fix(view-browser): actually elevate header above main for dropdown overlay
PR #105 added `header { z-index: 100; }` intending to put the
Recent-runs dropdown above `<main>`. It didn't work because there's
an earlier rule:
body > * { position: relative; z-index: 1; }
That selector has specificity (0,0,0,2) vs `header`'s (0,0,0,1), so
it overrode the bump. Both `<header>` and `<main>` ended up at
z-index 1 and source order made `<main>` paint on top — so the
dropdown was still being clipped by the highlighted scan-path
`<code>` and the dashboard cards.
Fixes by raising the header's z-index via a selector that matches
or beats `body > *`:
body > header { z-index: 100; }
The `.recent-scans-list` z-index 1000 inside header's stacking
context already wins against the dashboard cards, so this single
rule is enough. The earlier (now ineffective) `position: relative;
z-index: 100;` block on the bare `header` selector is dropped — a
comment near the original location points readers at the new
specificity-aware rule so the cause-of-the-fix is discoverable.
All 178 browser-viewer tests still pass.1 parent c68a1c9 commit 86b31ec
1 file changed
Lines changed: 9 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
162 | 168 | | |
163 | 169 | | |
164 | 170 | | |
| |||
168 | 174 | | |
169 | 175 | | |
170 | 176 | | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
177 | 180 | | |
178 | 181 | | |
179 | 182 | | |
| |||
0 commit comments