Avoid jobs to stay on `PROCESSING` state forever

[elreplicante]

It still can happen that some processes do not finish and will be in the db with a state of PROCESSING forever, maybe a better options instead of increase timeout is to stop the current job and set the state back to SCHEDULED ? this will ensure all evidences are going to get processed and stop times will be faster.

[daneryl]

i have also found examples of sites that just will never finish loading in puppeteer, this kind of sites will block our workers, should we implement a timeout to the preservation also ?

Edited:
this is not true, it was not stuck on puppeteer, was downloading hundreds of videos but not stuck, this is not an issue.

[txau]

@daneryl maybe assigning a size quota instead of a timeout?

[daneryl]

@daneryl maybe assigning a size quota instead of a timeout?

timeout seems not necessary anymore, since this was not stuck, just taking a long time, but maybe we need a quota at some point, with the new changes only one video will get downloaded when going to a page with a "list of videos" like youtube home, but this is whatever video is the first one i think, sometimes this is 10 or more GB, lets have a different issue for this one ? and maintain this one for only the Gracefull Shutdown thing.

[txau]

Downloading only the first video may leading to missing important information. While it works for some edge cases such as YouTube's home page, it doesn't work for tweets with more than one video.

I'm not sure if twitter allows more than one video per tweet, it does support more than one image per tweet. that is why having a quota seems like a better option to me.

[daneryl]

Downloading only the first video may leading to missing important information. While it works for some edge cases such as YouTube's home page, it doesn't work for tweets with more than one video.

I'm not sure if twitter allows more than one video per tweet, it does support more than one image per tweet. that is why having a quota seems like a better option to me.

Sure, the 1 video thing is a patch for now, so that specific sites do not block us, we actuallly where treating everything as if we are downloading 1 video anyways, we should talk about "extra videos" as an extra feature?, i think this should be good enough for mvp ?

[txau]

Yes, enough for the MVP. Just commenting to leave it documented.

[daneryl]

Cancelling current jobs to improve deployment time and never have "PROCESSING" jobs left in the database turns out not to be easy at all, for the mvp we are leaving the current strategy, stop the jobs and wait for max 5 minutes timeout for jobs to finish, if a job does not finish on the grace period, we will need to fix it manually for now