Merge pull request #16 from hussainweb/phplint-fix

pass extensions one at a time to phplint

Author: hussainweb

dist/index.js

@@ -11,13 +11,13 @@ module.exports = (options, webRoot) => {
     commandArray.push(`--exclude=${exclude}`);
   });
 
-  commandArray.push(
-    `--extensions=${
-      options.extensions
-        ? options.extensions
-        : "php,module,theme,engine,inc,install"
-    }`
-  );
+  const extensionsStr = options.extensions
+    ? options.extensions
+    : "php,module,theme,engine,inc,install";
+  extensionsStr.split(",").forEach((extension) => {
+    commandArray.push(`--extensions=${extension}`);
+  });
+
   if (options.verbose) {
     commandArray.push("-v");
   }

dist/index.js.map

@@ -1,37 +1,64 @@
-const phplint = require('./phplint');
+const phplint = require("./phplint");
 
-test('it returns defaults', () => {
-  expect(phplint({}, 'web')).toEqual(['phplint', '--exclude=vendor', '--exclude=web/core', '--exclude=web/modules/contrib', '--extensions=php,module,theme,engine,inc,install']);
+test("it returns defaults", () => {
+  expect(phplint({}, "web")).toEqual([
+    "phplint",
+    "--exclude=vendor",
+    "--exclude=web/core",
+    "--exclude=web/modules/contrib",
+    "--extensions=php",
+    "--extensions=module",
+    "--extensions=theme",
+    "--extensions=engine",
+    "--extensions=inc",
+    "--extensions=install",
+  ]);
 });
 
-test('it returns no options', () => {
-  expect(phplint({ no_default_options: true }, 'web')).toEqual(['phplint']);
-  expect(phplint({
-    no_default_options: true,
-    exclude: 'vendor',
-  }, 'web')).toEqual(['phplint']);
+test("it returns no options", () => {
+  expect(phplint({ no_default_options: true }, "web")).toEqual(["phplint"]);
+  expect(
+    phplint(
+      {
+        no_default_options: true,
+        exclude: "vendor",
+      },
+      "web"
+    )
+  ).toEqual(["phplint"]);
 });
 
-test('it handles partial inputs', () => {
+test("it handles partial inputs", () => {
   let command;
-  command = phplint({
-    exclude: 'vendor,web/themes/contrib',
-  }, 'web');
-  expect(command).toContain('--exclude=vendor');
-  expect(command).toContain('--exclude=web/themes/contrib');
-  expect(command).not.toContain('--exclude=web/modules/contrib');
+  command = phplint(
+    {
+      exclude: "vendor,web/themes/contrib",
+    },
+    "web"
+  );
+  expect(command).toContain("--exclude=vendor");
+  expect(command).toContain("--exclude=web/themes/contrib");
+  expect(command).not.toContain("--exclude=web/modules/contrib");
 
-  command = phplint({
-    extensions: 'php,inc',
-  }, 'docroot');
-  expect(command).toContain('--extensions=php,inc');
-  expect(command).toContain('--exclude=docroot/modules/contrib');
+  command = phplint(
+    {
+      extensions: "php,inc",
+    },
+    "docroot"
+  );
+  expect(command).toContain("--extensions=php");
+  expect(command).toContain("--extensions=inc");
+  expect(command).not.toContain("--extensions=module");
+  expect(command).toContain("--exclude=docroot/modules/contrib");
 
-  command = phplint({
-    verbose: true,
-    path: 'web/modules/custom',
-  }, 'docroot');
-  expect(command).toContain('-v');
-  expect(command).toContain('--exclude=docroot/modules/contrib');
-  expect(command).toContain('web/modules/custom');
+  command = phplint(
+    {
+      verbose: true,
+      path: "web/modules/custom",
+    },
+    "docroot"
+  );
+  expect(command).toContain("-v");
+  expect(command).toContain("--exclude=docroot/modules/contrib");
+  expect(command).toContain("web/modules/custom");
 });