HOMS-523 Guard each sign-in field independently

Email and Password are re-driven separately, so a value that failed to
stick in one field no longer depends on the other field having failed
too.

Author: kompl

Dockerfile.oracle

@@ -36,7 +36,7 @@ RUN seq 1 8 | xargs -I{} mkdir -p /usr/share/man/man{} && \
   telnet \
   unzip
 
-RUN npm install -g yarn && yarn set version stable
+RUN npm install -g corepack@latest && corepack enable
 
 WORKDIR /opt/oracle
 

spec/support/helpers/sessions_helper.rb

@@ -17,15 +17,16 @@ def sign_up_with(email, password, confirmation, name, middle_name,
 
     # rubocop:enable Metrics/ParameterLists
     def signin(email, password)
-      visit new_user_session_path
-      fill_in 'Email', with: email
-      fill_in 'Password', with: password
       # Also the path for the invalid-credentials specs, so this must assert nothing about the
-      # sign-in outcome — only that the typed value actually stuck before submitting.
-      unless page.has_field?('Email', with: email)
-        fill_in 'Email', with: email
-        fill_in 'Password', with: password
+      # sign-in outcome — only that each typed value actually stuck before submitting.
+      fill = lambda do |field, value|
+        fill_in field, with: value
+        fill_in field, with: value unless page.has_field?(field, with: value)
       end
+
+      visit new_user_session_path
+      fill.call('Email', email)
+      fill.call('Password', password)
       click_button 'Sign in'
     end