refactor(hydro_cli)!: use direct &dyn Any upcasting for Rust 1.86, update pyo3, fix #1821
#1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadaj
approved these changes
Apr 7, 2025
|
Seems to be an actual error |
|
So weird, something with pyo3 |
|
I am not sure how to get the hydrocli tests to actually run locally |
Need to Still ultra confused what broke here though (should we enable backtraces in CI?). |
MingweiSamuel
changed the title
&dyn Any upcasting for Rust 1.86, fix #1821&dyn Any upcasting for Rust 1.86, update pyo3, fix #1821
MingweiSamuel
changed the title
&dyn Any upcasting for Rust 1.86, update pyo3, fix #1821&dyn Any upcasting for Rust 1.86, update pyo3, fix #1821
|
Thinking this might be a genuine bug in the python code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1821
https://pyo3.rs/v0.23.0/migration#from-020-to-021
BREAKING CHANGE: Now uses pyo3 0.24