fix iOS IAP listener cleanup crash

Author: MadeinFrance

libraries/react-native-iap/src/__tests__/hooks/useIAP.test.ts

@@ -121,6 +121,60 @@ describe('hooks/useIAP (renderer)', () => {
     expect(IAP.finishTransaction).toBeDefined();
   });
 
+  it('skips purchase success when unmounted while refresh is pending', async () => {
+    let resolveActiveSubscriptions: (() => void) | undefined;
+    mockGetActiveSubscriptions.mockImplementation(
+      () =>
+        new Promise((resolve) => {
+          resolveActiveSubscriptions = () => resolve([]);
+        }) as any,
+    );
+
+    const onPurchaseSuccess = jest.fn();
+    const Harness = () => {
+      useIAP({onPurchaseSuccess});
+      return null;
+    };
+
+    let renderer: ReturnType<typeof TestRenderer.create>;
+    await act(async () => {
+      renderer = TestRenderer.create(React.createElement(Harness));
+    });
+    await act(async () => {});
+
+    const purchase = {
+      id: 't1',
+      productId: 'p1',
+      transactionDate: Date.now(),
+      platform: 'ios',
+      store: 'apple',
+      quantity: 1,
+      purchaseState: 'purchased',
+      isAutoRenewing: false,
+    };
+    if (!capturedPurchaseListener) {
+      throw new Error('purchase listener was not initialized');
+    }
+
+    const purchaseUpdate = capturedPurchaseListener(purchase);
+
+    if (!resolveActiveSubscriptions) {
+      throw new Error('active subscriptions resolver was not initialized');
+    }
+    const resolvePendingActiveSubscriptions = resolveActiveSubscriptions;
+
+    await act(async () => {
+      renderer.unmount();
+    });
+
+    await act(async () => {
+      resolvePendingActiveSubscriptions();
+      await purchaseUpdate;
+    });
+
+    expect(onPurchaseSuccess).not.toHaveBeenCalled();
+  });
+
   it('requestPurchase calls root API and returns void', async () => {
     const mockRequestPurchase = jest
       .spyOn(IAP, 'requestPurchase')

libraries/react-native-iap/src/__tests__/index.test.ts

@@ -214,7 +214,7 @@ describe('Public API (src/index.ts)', () => {
       expect(duplicateListener).toHaveBeenCalledTimes(1);
     });
 
-    it('removes purchase updated native listener by token after the last JS listener is removed', () => {
+    it('removes iOS purchase updated JS listeners without removing the native listener', () => {
       const listener1 = jest.fn();
       const listener2 = jest.fn();
       const sub1 = IAP.purchaseUpdatedListener(listener1);
@@ -226,23 +226,21 @@ describe('Public API (src/index.ts)', () => {
 
       sub2.remove();
       sub2.remove();
-      expect(mockIap.removePurchaseUpdatedListener).toHaveBeenCalledTimes(1);
-      expect(mockIap.removePurchaseUpdatedListener).toHaveBeenCalledWith(1);
+      expect(mockIap.removePurchaseUpdatedListener).not.toHaveBeenCalled();
     });
 
-    it('removes non-deduping purchase updated native listener by its own token', () => {
+    it('removes iOS non-deduping purchase updated JS listener without removing the native listener', () => {
       const defaultSub = IAP.purchaseUpdatedListener(jest.fn());
       const duplicateSub = IAP.purchaseUpdatedListener(jest.fn(), {
         dedupeTransactionIOS: false,
       });
 
       expect(mockIap.addPurchaseUpdatedListener).toHaveBeenCalledTimes(2);
       duplicateSub.remove();
-      expect(mockIap.removePurchaseUpdatedListener).toHaveBeenCalledWith(2);
+      expect(mockIap.removePurchaseUpdatedListener).not.toHaveBeenCalled();
 
       defaultSub.remove();
-      expect(mockIap.removePurchaseUpdatedListener).toHaveBeenCalledWith(1);
-      expect(mockIap.removePurchaseUpdatedListener).toHaveBeenCalledTimes(2);
+      expect(mockIap.removePurchaseUpdatedListener).not.toHaveBeenCalled();
     });
 
     it('purchaseErrorListener forwards error objects and supports removal', () => {

libraries/react-native-iap/src/hooks/useIAP.ts

@@ -585,12 +585,21 @@ export function useIAP(options?: UseIapOptions): UseIap {
     if (!subscriptionsRef.current.purchaseUpdate) {
       subscriptionsRef.current.purchaseUpdate = purchaseUpdatedListener(
         async (purchase: Purchase) => {
+          if (!isMountedRef.current) {
+            return;
+          }
+
           try {
             await getActiveSubscriptionsInternal();
             await getAvailablePurchasesInternal();
           } catch (e) {
             RnIapConsole.warn('[useIAP] post-purchase refresh failed:', e);
           }
+
+          if (!isMountedRef.current) {
+            return;
+          }
+
           if (optionsRef.current?.onPurchaseSuccess) {
             optionsRef.current.onPurchaseSuccess(purchase);
           }
@@ -602,6 +611,10 @@ export function useIAP(options?: UseIapOptions): UseIap {
     if (!subscriptionsRef.current.purchaseError) {
       subscriptionsRef.current.purchaseError = purchaseErrorListener(
         (error) => {
+          if (!isMountedRef.current) {
+            return;
+          }
+
           if (
             error.code === ErrorCode.InitConnection &&
             !connectedRef.current
@@ -618,6 +631,10 @@ export function useIAP(options?: UseIapOptions): UseIap {
     if (isStandardIOS() && !subscriptionsRef.current.promotedProductIOS) {
       subscriptionsRef.current.promotedProductIOS = promotedProductListenerIOS(
         (product: Product) => {
+          if (!isMountedRef.current) {
+            return;
+          }
+
           setPromotedProductIOS(product);
           if (optionsRef.current?.onPromotedProductIOS) {
             optionsRef.current.onPromotedProductIOS(product);
@@ -655,6 +672,10 @@ export function useIAP(options?: UseIapOptions): UseIap {
     if (!subscriptionsRef.current.subscriptionBillingIssue) {
       subscriptionsRef.current.subscriptionBillingIssue =
         subscriptionBillingIssueListener((purchase: Purchase) => {
+          if (!isMountedRef.current) {
+            return;
+          }
+
           optionsRef.current?.onSubscriptionBillingIssue?.(purchase);
         });
     }

libraries/react-native-iap/src/index.ts

@@ -451,6 +451,13 @@ export const purchaseUpdatedListener = (
         return;
       }
 
+      // StoreKit-backed Nitro listener disposal can abort in iOS release builds
+      // when a native modal is being popped. Keep the singleton native listener
+      // attached for the app session and only remove the JS callback above.
+      if (Platform.OS === 'ios') {
+        return;
+      }
+
       const token = receiveDuplicateTransactionUpdatesIOS
         ? purchaseUpdateDuplicateNativeToken
         : purchaseUpdateNativeToken;