Merge pull request #1010 from hypar-io/ifc-openings-for-instances

instance openings for ifc (#1010)

Author: anthonie-kramer

Elements.Serialization.IFC/src/Serialization/IFC/IFCElementExtensions.cs

@@ -30,12 +30,27 @@ internal static List<IfcProduct> ToIfcProducts(this Element e,
             if (e is ElementInstance)
             {
                 // If we're using an element instance, get the transform
-                // and the id and use those to uniquely position and 
+                // and the id and use those to uniquely position and
                 // identify the element.
                 var instance = (ElementInstance)e;
                 geoElement = instance.BaseDefinition;
                 id = instance.Id;
                 trans = instance.Transform;
+
+                if (geoElement is IHasOpenings geoElementWithOpenings)
+                {
+                    for (int i = 0; i < geoElementWithOpenings.Openings.Count; i++)
+                    {
+                        Opening opening = geoElementWithOpenings.Openings[i];
+                        var transform = opening.Transform.Concatenated(trans);
+                        var newOpening = new Opening(opening.Perimeter, opening.DepthFront, opening.DepthBack, transform,
+                            opening.Representation, opening.IsElementDefinition, default, opening.Name);
+
+                        ToIfcProducts(newOpening, context, doc, styleAssignments, updateElementRepresentation);
+
+                        geoElementWithOpenings.Openings[i] = newOpening;
+                    }
+                }
             }
             else if (e is GeometricElement)
             {
@@ -75,17 +90,17 @@ internal static List<IfcProduct> ToIfcProducts(this Element e,
                     if (op is Sweep sweep)
                     {
 
-                        // Neither of these entities, which are part of the 
-                        // IFC4 specification, and which would allow a sweep 
-                        // along a curve, are supported by many applications 
+                        // Neither of these entities, which are part of the
+                        // IFC4 specification, and which would allow a sweep
+                        // along a curve, are supported by many applications
                         // which are supposedly IFC4 compliant (Revit). For
                         // Those applications where these entities appear,
-                        // the rotation of the profile is often wrong or 
+                        // the rotation of the profile is often wrong or
                         // inconsistent.
                         // geom = sweep.ToIfcSurfaceCurveSweptAreaSolid(doc);
                         // geom = sweep.ToIfcFixedReferenceSweptAreaSolid(geoElement.Transform, doc);
 
-                        // Instead, we'll divide the curve and create a set of 
+                        // Instead, we'll divide the curve and create a set of
                         // linear extrusions instead.
                         Polyline pline;
                         if (sweep.Curve is Line)
@@ -169,7 +184,7 @@ internal static List<IfcProduct> ToIfcProducts(this Element e,
 
             // If the element has openings, make opening relationships in
             // the IfcElement.
-            if (e is IHasOpenings openings)
+            if (geoElement is IHasOpenings openings)
             {
                 if (openings.Openings.Count > 0)
                 {
@@ -232,7 +247,7 @@ private static IfcDoorTypeOperationEnum GetIfcDoorTypeOperation(this Door door)
         {
             if (door.OpeningType == DoorOpeningType.SingleSwing)
             {
-                switch(door.OpeningSide)
+                switch (door.OpeningSide)
                 {
                     case DoorOpeningSide.LeftHand:
                         return IfcDoorTypeOperationEnum.SINGLE_SWING_LEFT;
@@ -241,7 +256,7 @@ private static IfcDoorTypeOperationEnum GetIfcDoorTypeOperation(this Door door)
                     case DoorOpeningSide.DoubleDoor:
                         return IfcDoorTypeOperationEnum.DOUBLE_DOOR_SINGLE_SWING;
                 }
-            } 
+            }
             else if (door.OpeningType == DoorOpeningType.DoubleSwing)
             {
                 switch (door.OpeningSide)
@@ -274,7 +289,9 @@ internal static IfcLocalPlacement ToIfcLocalPlacement(this Transform transform,
 
         internal static IfcExtrudedAreaSolid ToIfcExtrudedAreaSolid(this Extrude extrude, Document doc)
         {
-            var position = new Transform().ToIfcAxis2Placement3D(doc);
+            // Add local transform to the IFC placement
+            var transform = extrude.LocalTransform ?? new Transform();
+            var position = transform.ToIfcAxis2Placement3D(doc);
 
             var extrudeDepth = extrude.Height;
             var extrudeProfile = extrude.Profile.Perimeter.ToIfcArbitraryClosedProfileDef(doc);
@@ -301,7 +318,7 @@ private static IfcBoundedCurve ToIfcCurve(this ICurve curve, Document doc)
             {
                 return arc.ToIfcTrimmedCurve(doc);
             }
-            // Test Polygon before Polyline to avoid 
+            // Test Polygon before Polyline to avoid
             // Polygons being treated as Polylines.
             else if (curve is Polygon polygon)
             {
@@ -527,7 +544,7 @@ private static IfcSlab ToIfc(this Floor floor, Guid id,
         }
 
         // TODO: There is a lot of duplicate code used to create products.
-        // Can we make a generic method like ToIfc<TProduct>()? There are 
+        // Can we make a generic method like ToIfc<TProduct>()? There are
         // exceptions for which this won't work like IfcSpace.
 
         private static IfcSpace ToIfc(this Space space, Guid id,

Elements.Serialization.IFC/test/Elements.Serialization.IFC.Tests.csproj

@@ -18,4 +18,8 @@
     <ProjectReference Include="..\src\Elements.Serialization.IFC.csproj" />
   </ItemGroup>
 
+  <ItemGroup>
+    <Folder Include="models\Hypar\" />
+  </ItemGroup>
+
 </Project>

Elements.Serialization.IFC/test/IFCTests.cs

@@ -7,6 +7,7 @@
 using Xunit.Abstractions;
 using System.Collections.Generic;
 using Elements.Geometry.Profiles;
+using System.Linq;
 
 namespace Elements.IFC.Tests
 {
@@ -56,6 +57,26 @@ public void IFC2X3(string name, string ifcPath, string[] idsToConvert = null)
             model.ToGlTF(ConstructGlbPath(name));
         }
 
+        [Fact]
+        public void InstanceOpenings()
+        {
+            var model = System.IO.File.ReadAllText("../../../models/Hypar/instance-openings-test-model.json");
+            var hyparModel = Model.FromJson(model);
+            var walls = hyparModel.AllElementsOfType<StandardWall>();
+            var path = ConstructIfcPath("instance-openings-test");
+            hyparModel.ToIFC(path);
+
+            var file = System.IO.File.ReadAllLines(path);
+
+            var wallCount = file.Count(x => x.Contains("IFCWALLSTANDARDCASE"));
+            var openingCount = file.Count(x => x.Contains("IFCRELVOIDSELEMENT"));
+            var floorCount = file.Count(x => x.Contains("IFCSLAB"));
+
+            Assert.Equal(wallCount, 4);
+            Assert.Equal(openingCount, 5);
+            Assert.Equal(floorCount, 1);
+        }
+
         [Fact]
         public void Doors()
         {