Merge pull request #28 from hypercerts-org/fix/formatter

MIME type validation formattes

Author: bitbeckers

Diff for: src/validator/validators/PropertyValidator.ts

@@ -18,7 +18,7 @@ interface GeoJSONProperty {
 }
 
 class GeoJSONValidationStrategy implements PropertyValidationStrategy {
-  private readonly MIME_TYPE = "applications/geo+json";
+  private readonly MIME_TYPE = "application/geo+json";
 
   validate(property: NonNullable<PropertyValue>): ValidationError[] {
     if (!this.isGeoJSONProperty(property)) {

Diff for: test/utils/formatter.test.ts

@@ -20,6 +20,12 @@ const testData: Partial<TestDataType> = {
   properties: [
     { trait_type: "test trait type", value: "aaa" },
     { trait_type: "test trait type", type: "image", src: "https://example.com", name: "test name" },
+    {
+      trait_type: "geoJSON",
+      type: "application/geo+json",
+      name: "oceanus-conservation-barangay.geojson",
+      src: "ipfs://bafkreifhfoozmhdtjn2y4xqtosuf26mxr2sxzvrrprkucglgotx3ok362a",
+    },
   ],
   rights: ["test right 1", "test right 2"],
   version: "0.0.1",
@@ -33,6 +39,9 @@ describe("Format Hypercert Data test", () => {
   it("checks correct metadata and returns result", () => {
     const result = formatHypercertData(testData as TestDataType);
 
+    expect(result.valid).to.be.true;
+    expect(result.data).to.not.be.null;
+
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     const validKeys = Object.keys(result.data!);
 

Diff for: test/validator/validators/MetadataValidator.test.ts

@@ -74,7 +74,7 @@ describe("MetadataValidator", () => {
           },
           {
             trait_type: "geoJSON",
-            type: "applications/geo+json",
+            type: "application/geo+json",
             src: "ipfs://QmExample",
             name: "location.geojson",
           },
@@ -164,7 +164,7 @@ describe("MetadataValidator", () => {
           },
           {
             trait_type: "geoJSON",
-            type: "applications/geo+json",
+            type: "application/geo+json",
             src: "ipfs://QmExample",
             name: "location.geojson",
           },

Diff for: test/validator/validators/PropertyValidator.test.ts

@@ -32,7 +32,7 @@ describe("PropertyValidator", () => {
     it("should validate a valid geoJSON property", () => {
       const property = {
         trait_type: "geoJSON",
-        type: "applications/geo+json",
+        type: "application/geo+json",
         src: "ipfs://QmExample",
         name: "location.geojson",
       };
@@ -45,7 +45,7 @@ describe("PropertyValidator", () => {
     it("should accept HTTPS source", () => {
       const property = {
         trait_type: "geoJSON",
-        type: "applications/geo+json",
+        type: "application/geo+json",
         src: "https://example.com/location.geojson",
         name: "location.geojson",
       };
@@ -67,14 +67,14 @@ describe("PropertyValidator", () => {
       expect(result.errors).to.deep.include({
         field: "type",
         code: "invalid_mime_type",
-        message: "GeoJSON type must be applications/geo+json",
+        message: "GeoJSON type must be application/geo+json",
       });
     });
 
     it("should reject invalid source URL", () => {
       const property = {
         trait_type: "geoJSON",
-        type: "applications/geo+json",
+        type: "application/geo+json",
         src: "invalid://QmExample",
         name: "location.geojson",
       };
@@ -91,7 +91,7 @@ describe("PropertyValidator", () => {
     it("should reject invalid file extension", () => {
       const property = {
         trait_type: "geoJSON",
-        type: "applications/geo+json",
+        type: "application/geo+json",
         src: "ipfs://QmExample",
         name: "location.wrong",
       };

Diff for: vitest.config.ts

@@ -10,7 +10,7 @@ export default defineConfig({
       // If you want a coverage reports even if your tests are failing, include the reportOnFailure option
       reportOnFailure: true,
       thresholds: {
-        lines: 73,
+        lines: 77,
         branches: 84,
         functions: 76,
         statements: 77,