Merge branch 'main' into dependabot/npm_and_yarn/picomatch-2.3.2

Author: kodiakhq[bot]

.github/workflows/release.yaml

@@ -37,6 +37,15 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_CONFIG_PROVENANCE: true
+      # Re-checkout to restore changeset files consumed by the changesets action above.
+      # Without this, `changeset version --snapshot next` finds no changesets and
+      # publishes full release versions to the `next` tag instead of snapshots.
+      - name: Restore checkout for snapshot
+        if: steps.changesets.outputs.published != 'true' && steps.changesets.outputs.hasChangesets == 'true'
+        uses: actions/checkout@v4
+      - name: Install dependencies for snapshot
+        if: steps.changesets.outputs.published != 'true' && steps.changesets.outputs.hasChangesets == 'true'
+        run: yarn
       - name: Publish snapshot to next tag
         if: steps.changesets.outputs.published != 'true' && steps.changesets.outputs.hasChangesets == 'true'
         run: yarn run release:next

lint-staged.config.js

@@ -2,8 +2,12 @@ module.exports = {
   '**/*.{ts,tsx}': (files) => {
     const cmds = [`prettier --write --ignore-unknown ${files.join(' ')}`];
 
-    // `otel-web` package does not have an eslint config yet
-    const lintable = files.filter((f) => !f.includes('/packages/otel-web/'));
+    // These packages do not have an eslint config yet
+    const lintable = files.filter(
+      (f) =>
+        !f.includes('/packages/otel-web/') &&
+        !f.includes('/packages/session-recorder/'),
+    );
 
     if (lintable.length) {
       cmds.push(`eslint --fix ${lintable.join(' ')}`);

packages/browser/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @hyperdx/browser
 
+## 0.23.0
+
+### Minor Changes
+
+- 057f3b9: Emit FCP and TTFB Core Web Vitals from the browser RUM SDK. The bundled
+  `web-vitals` library already exports `onFCP` and `onTTFB`; `initWebVitals`
+  now registers callbacks for them alongside the existing LCP / INP / CLS / FID
+  ones. Each new metric lands as a `webvitals` span with the value on a single
+  attribute (`fcp` or `ttfb`), matching the existing pattern.
+
+### Patch Changes
+
+- Updated dependencies [057f3b9]
+  - @hyperdx/otel-web@0.17.0
+  - @hyperdx/otel-web-session-recorder@1.0.0
+
 ## 0.22.1
 
 ### Patch Changes

packages/browser/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@hyperdx/browser",
-  "version": "0.22.1",
+  "version": "0.23.0",
   "license": "Apache-2.0",
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "dependencies": {
-    "@hyperdx/otel-web": "0.16.4",
-    "@hyperdx/otel-web-session-recorder": "0.16.2"
+    "@hyperdx/otel-web": "0.17.0",
+    "@hyperdx/otel-web-session-recorder": "1.0.0"
   },
   "devDependencies": {
     "@rollup/plugin-commonjs": "^24.1.0",

packages/instrumentation-exception/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @hyperdx/instrumentation-exception
 
+## 0.2.0
+
+### Minor Changes
+
+- 65be0bd: Improve how instrumation-exception stringifies properties like arrays and objects
+
 ## 0.1.0
 
 ### Minor Changes

packages/instrumentation-exception/package.json

@@ -2,7 +2,7 @@
   "name": "@hyperdx/instrumentation-exception",
   "author": "Warren <warren@users.noreply.github.com>",
   "license": "Apache-2.0",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "homepage": "https://www.hyperdx.io",
   "repository": {
     "type": "git",

packages/instrumentation-exception/src/browser/instrumentations/HyperDXErrorInstrumentation.ts

@@ -6,7 +6,7 @@ import {
 import * as shimmer from 'shimmer';
 
 import { recordException } from '../';
-import { getElementXPath, limitLen } from './utils';
+import { getElementXPath, limitLen, stringifyValue } from './utils';
 
 // FIXME take timestamps from events?
 
@@ -17,14 +17,6 @@ function useful(s) {
   return s && s.trim() !== '' && !s.startsWith('[object') && s !== 'error';
 }
 
-function stringifyValue(value: unknown) {
-  if (value === undefined) {
-    return '(undefined)';
-  }
-
-  return value.toString();
-}
-
 function addStackIfUseful(span: Span, err: Error) {
   if (err && err.stack && useful(err.stack)) {
     span.setAttribute(
@@ -210,7 +202,7 @@ export class HyperDXErrorInstrumentation extends InstrumentationBase {
         firstError,
       );
     } else {
-      this.hdxReportString(source, stringifyValue(arg)); // FIXME or JSON.stringify?
+      this.hdxReportString(source, stringifyValue(arg));
     }
   }
 }

packages/instrumentation-exception/src/browser/instrumentations/__tests__/HyperDXErrorInstrumentation.test.ts

@@ -0,0 +1,104 @@
+import { stringifyValue } from '../utils';
+
+describe('stringifyValue', () => {
+  it('should JSON.stringify plain objects instead of producing [object Object]', () => {
+    const obj = { errorId: 'abc-123', details: 'something broke' };
+    const result = stringifyValue(obj);
+
+    expect(result).not.toContain('[object Object]');
+    expect(result).toContain('errorId');
+    expect(result).toContain('abc-123');
+    expect(result).toBe('{"errorId":"abc-123","details":"something broke"}');
+  });
+
+  it('should handle nested objects', () => {
+    const result = stringifyValue({ outer: { inner: 'value' } });
+
+    expect(result).not.toContain('[object Object]');
+    expect(result).toContain('inner');
+    expect(result).toBe('{"outer":{"inner":"value"}}');
+  });
+
+  it('should handle null', () => {
+    expect(stringifyValue(null)).toBe('null');
+  });
+
+  it('should handle undefined', () => {
+    expect(stringifyValue(undefined)).toBe('(undefined)');
+  });
+
+  it('should use error.message for Error objects instead of JSON.stringify', () => {
+    const err = new Error('something failed');
+    const result = stringifyValue(err);
+
+    // JSON.stringify(err) would produce "{}" because Error properties are non-enumerable
+    expect(result).not.toBe('{}');
+    expect(result).toContain('something failed');
+  });
+
+  it('should handle Error objects with no message', () => {
+    const err = new Error();
+    const result = stringifyValue(err);
+
+    // Should fall back to toString() which gives "Error"
+    expect(result).toBeTruthy();
+  });
+
+  it('should return empty string for empty objects', () => {
+    expect(stringifyValue({})).toBe('');
+  });
+
+  it('should return empty string for empty arrays', () => {
+    expect(stringifyValue([])).toBe('');
+  });
+
+  it('should handle non-empty arrays', () => {
+    const result = stringifyValue([1, 2, 3]);
+
+    expect(result).not.toContain('[object Object]');
+    expect(result).toBe('[1,2,3]');
+  });
+
+  it('should handle strings as-is', () => {
+    expect(stringifyValue('hello')).toBe('hello');
+  });
+
+  it('should handle numbers', () => {
+    expect(stringifyValue(42)).toBe('42');
+  });
+
+  it('should handle booleans', () => {
+    expect(stringifyValue(true)).toBe('true');
+    expect(stringifyValue(false)).toBe('false');
+  });
+
+  it('should handle objects with circular references gracefully', () => {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    const obj: any = { a: 1 };
+    obj.self = obj;
+
+    // Should not throw, falls back to toString()
+    const result = stringifyValue(obj);
+    expect(result).toBeDefined();
+  });
+
+  it('should produce correct output for the reported console.error scenario', () => {
+    // Simulates: console.error('FatalErrorBoundary caught an error', { errorId, error, errorInfo })
+    // The hdxReport method joins stringifyValue results with spaces
+    const args = [
+      'FatalErrorBoundary caught an error',
+      {
+        errorId: 'err-001',
+        error: 'TypeError: Cannot read properties of null',
+        errorInfo: { componentStack: 'at App' },
+      },
+    ];
+
+    const message = args.map((x) => stringifyValue(x)).join(' ');
+
+    expect(message).not.toContain('[object Object]');
+    expect(message).toContain('FatalErrorBoundary caught an error');
+    expect(message).toContain('errorId');
+    expect(message).toContain('err-001');
+  });
+});

packages/instrumentation-exception/src/browser/instrumentations/utils.ts

@@ -1,3 +1,32 @@
+export function stringifyValue(value: unknown): string {
+  if (value === undefined) {
+    return '(undefined)';
+  }
+
+  if (value === null) {
+    return 'null';
+  }
+
+  if (value instanceof Error) {
+    return value.message || value.toString();
+  }
+
+  if (typeof value === 'object') {
+    try {
+      const result = JSON.stringify(value);
+      // Empty objects/arrays carry no useful error info
+      if (result === '{}' || result === '[]') {
+        return '';
+      }
+      return result;
+    } catch (e) {
+      return value.toString();
+    }
+  }
+
+  return value.toString();
+}
+
 export function limitLen(s: string, cap: number): string {
   if (s.length > cap) {
     return s.substring(0, cap);

packages/node-opentelemetry/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @hyperdx/node-opentelemetry
 
+## 0.10.4
+
+### Patch Changes
+
+- Updated dependencies [65be0bd]
+  - @hyperdx/instrumentation-exception@0.2.0
+
 ## 0.10.3
 
 ### Patch Changes