Skip to content

Commit dbe83e5

Browse files
Fix forceEnabled override: use boolean comparison for localStorage
Mantine's useLocalStorage deserializes with JSON.parse, so a raw localStorage.setItem('hdx-feedback-enabled', 'true') yields boolean true, not string 'true'. Changed the hook type to boolean and comparison to === true so the override actually works. Co-authored-by: Mike Shi <mike@hyperdx.io>
1 parent 2e96d36 commit dbe83e5

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

packages/app/src/components/AppNav/AppNavFeedback.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ const FORCE_ENABLE_KEY = 'hdx-feedback-enabled';
3232

3333
export const AppNavFeedback = () => {
3434
const { isCollapsed } = React.useContext(AppNavContext);
35-
const [forceEnabled] = useLocalStorage<string>({
35+
const [forceEnabled] = useLocalStorage<boolean>({
3636
key: FORCE_ENABLE_KEY,
37-
defaultValue: '',
37+
defaultValue: false,
3838
});
3939
const [hidden, setHidden] = useLocalStorage<boolean>({
4040
key: 'feedbackHidden',
@@ -48,7 +48,7 @@ export const AppNavFeedback = () => {
4848

4949
// Only show when HyperDX SDK is active (non-local mode),
5050
// or when overridden via: localStorage.setItem('hdx-feedback-enabled', 'true')
51-
const sdkEnabled = !IS_LOCAL_MODE || forceEnabled === 'true';
51+
const sdkEnabled = !IS_LOCAL_MODE || forceEnabled === true;
5252

5353
const reset = useCallback(() => {
5454
setVote(null);

0 commit comments

Comments
 (0)