Cleanup specs

Author: teeohhem

packages/app/tests/e2e/features/search/search-filters.spec.ts

@@ -14,48 +14,25 @@ test.describe('Search Filters', { tag: ['@search', '@local-mode'] }, () => {
       await severityControl.click();
       await page.waitForTimeout(500);
 
-      const errorFilterCheckbox = page.locator('[data-testid="filter-checkbox-error"]');
+      const errorFilterCheckbox = page.locator('[data-testid="filter-checkbox-input-error"]');
       await expect(errorFilterCheckbox).toBeVisible();
       await errorFilterCheckbox.click();
-      await page.waitForTimeout(1000);
-      
-      const errorCheckboxInput = page.locator('[data-testid="filter-checkbox-input-error"]');
-      await expect(errorCheckboxInput).toBeChecked();
-      
-      await page.waitForLoadState('networkidle');
-      await page.waitForTimeout(2000);
-      
+      await expect(errorFilterCheckbox).toBeChecked();
       const searchResults = page.locator('[data-testid="search-results-table"]');
       await expect(searchResults).toBeVisible();
+      //todo: Check counts and accuracy of results
     });
 
     await test.step('Exclude error filter', async () => {
       const errorFilterCheckbox = page.locator('[data-testid="filter-checkbox-error"]');
       await errorFilterCheckbox.hover();
-      await page.waitForTimeout(500);
 
-      const excludeButton = page.locator('[data-testid="filter-exclude-error"]');
+      const excludeButton = page.locator('[data-testid="filter-exclude-error"]').first();
       await expect(excludeButton).toBeVisible();
       await excludeButton.click();
-      await page.waitForTimeout(1000);
-      
-      // Wait for the filter state to update and verify exclusion
+      await page.waitForTimeout(500);
       const errorCheckboxInput = page.locator('[data-testid="filter-checkbox-input-error"]');
-      
-      // Wait for the exclude state to be applied - check for indeterminate state
-      await page.waitForFunction(
-        (selector) => {
-          const checkbox = document.querySelector(selector) as HTMLInputElement;
-          return checkbox && checkbox.indeterminate === true;
-        },
-        '[data-testid="filter-checkbox-input-error"]',
-        { timeout: 5000 }
-      );
-      
-      // Verify the indeterminate state
-      const isIndeterminate = await errorCheckboxInput.evaluate((el: HTMLInputElement) => el.indeterminate);
-      expect(isIndeterminate).toBe(true);
-      
+      await expect(errorCheckboxInput).toHaveAttribute('data-indeterminate', 'true');
       await page.waitForLoadState('networkidle');
       await page.waitForTimeout(2000);
     });
@@ -86,10 +63,7 @@ test.describe('Search Filters', { tag: ['@search', '@local-mode'] }, () => {
       const excludeButton = page.locator('[data-testid="filter-exclude-error"]');
 
       await errorFilterCheckbox.hover();
-      await page.waitForTimeout(500);
       await excludeButton.click();
-      await page.waitForTimeout(500);
-      
       await errorFilterCheckbox.hover();
       await page.waitForTimeout(500);
 

packages/app/tests/e2e/features/sessions.spec.ts

@@ -19,7 +19,6 @@ test.describe('Client Sessions Functionality', { tag: ['@sessions', '@local-mode
         '[data-testid="sessions-search-form"]',
         'input[placeholder="Data Source"]',
         '.mantine-Select-input',
-        'text=Data Source'
       ];
 
       for (const selector of selectors) {