Remove redundant setAccessible methods (#5811)

Author: huangdijia

src/Aop/RegisterInjectPropertyHandler.php

@@ -35,7 +35,6 @@ public static function register()
             if ($annotation instanceof Inject) {
                 try {
                     $reflectionProperty = ReflectionManager::reflectProperty($currentClassName, $property);
-                    $reflectionProperty->setAccessible(true);
                     $container = ApplicationContext::getContainer();
                     if ($container->has($annotation->value)) {
                         $reflectionProperty->setValue($object, $container->get($annotation->value));

tests/Annotation/ScannerTest.php

@@ -35,6 +35,10 @@
  * @coversNothing
  */
 #[CoversNothing]
+/**
+ * @internal
+ * @coversNothing
+ */
 class ScannerTest extends TestCase
 {
     protected function tearDown(): void
@@ -61,7 +65,6 @@ public function testGetChangedAspects()
         $scanner = new Scanner(new ScanConfig(false, '/'), new NullScanHandler());
         $ref = new ReflectionClass($scanner);
         $property = $ref->getProperty('filesystem');
-        $property->setAccessible(true);
         $property->setValue($scanner, $filesystem = Mockery::mock(Filesystem::class . '[lastModified]'));
         $times = [
             Debug1Aspect::class => 5,
@@ -73,7 +76,6 @@ public function testGetChangedAspects()
         });
 
         $method = $ref->getMethod('getChangedAspects');
-        $method->setAccessible(true);
 
         $reader = new AnnotationReader();
         $scanner->collect($reader, ReflectionManager::reflectClass(Debug2Aspect::class));

tests/AnnotationTest.php

@@ -25,6 +25,10 @@
  * @coversNothing
  */
 #[CoversNothing]
+/**
+ * @internal
+ * @coversNothing
+ */
 class AnnotationTest extends TestCase
 {
     protected function tearDown(): void
@@ -37,7 +41,6 @@ public function testScanAnnotationsDirectoryNotExist()
         $scanner = new Scanner(new ScanConfig(false, '/'), new NullScanHandler());
         $ref = new ReflectionClass($scanner);
         $method = $ref->getMethod('normalizeDir');
-        $method->setAccessible(true);
 
         $this->expectException(DirectoryNotExistException::class);
         $method->invokeArgs($scanner, [['/not_exists']]);
@@ -48,7 +51,6 @@ public function testScanAnnotationsDirectoryEmpty()
         $scanner = new Scanner(new ScanConfig(false, '/'), new NullScanHandler());
         $ref = new ReflectionClass($scanner);
         $method = $ref->getMethod('normalizeDir');
-        $method->setAccessible(true);
 
         $this->assertSame([], $method->invokeArgs($scanner, [[]]));
     }

tests/Aop/ProxyCallVisitorTest.php

@@ -26,6 +26,10 @@
  * @coversNothing
  */
 #[CoversNothing]
+/**
+ * @internal
+ * @coversNothing
+ */
 class ProxyCallVisitorTest extends TestCase
 {
     protected function tearDown(): void
@@ -58,7 +62,6 @@ protected function bar()
         $proxyCallVisitor = new ProxyCallVisitor(new VisitorMetadata('SomeClass'));
 
         $reflectionMethod = new ReflectionMethod($proxyCallVisitor, 'shouldRewrite');
-        $reflectionMethod->setAccessible(true);
         $this->assertFalse($reflectionMethod->invoke($proxyCallVisitor, $stmts->stmts[0]));
         $this->assertTrue($reflectionMethod->invoke($proxyCallVisitor, $stmts->stmts[1]));
     }
@@ -74,7 +77,6 @@ public function testInterfaceShouldNotRewrite()
         $proxyCallVisitor = new ProxyCallVisitor($visitorMetadata);
 
         $reflectionMethod = new ReflectionMethod($proxyCallVisitor, 'shouldRewrite');
-        $reflectionMethod->setAccessible(true);
         $this->assertTrue($reflectionMethod->invoke($proxyCallVisitor, new ClassMethod('foo')));
 
         $visitorMetadata->classLike = Node\Stmt\Interface_::class;

tests/ClassLoaderTest.php

@@ -23,6 +23,10 @@
  * @coversNothing
  */
 #[CoversNothing]
+/**
+ * @internal
+ * @coversNothing
+ */
 class ClassLoaderTest extends TestCase
 {
     public function testDotEnv()
@@ -35,7 +39,6 @@ public function __construct()
 
         $ref = new ReflectionClass($class);
         $method = $ref->getMethod('loadDotenv');
-        $method->setAccessible(true);
         $method->invoke($class);
 
         $this->assertNotEquals('0.0.0', env('SW_VERSION'));