Skip to content

Commit 56a112f

Browse files
authored
feat: normalization handler for comment keyword (#252)
* test: add failing test for * feat: register normalization handler for comment
1 parent 29e832a commit 56a112f

3 files changed

Lines changed: 30 additions & 0 deletions

File tree

src/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import additionalItemsNormalizationHandler from "./normalization-handlers/draft-
55
import additionalPropertiesNormalizationHandler from "./normalization-handlers/additionalProperties.js";
66
import allOfNormalizationHandler from "./normalization-handlers/allOf.js";
77
import anyOfNormalizationHandler from "./normalization-handlers/anyOf.js";
8+
import commentNormalizationHandler from "./normalization-handlers/comment.js";
89
import constNormalizationHandler from "./normalization-handlers/const.js";
910
import containsNormalizationHandler from "./normalization-handlers/contains.js";
1011
import containsDraft06NormalizationHandler from "./normalization-handlers/draft-06/contains.js";
@@ -86,6 +87,7 @@ setNormalizationHandler("https://json-schema.org/keyword/draft-04/additionalItem
8687
setNormalizationHandler("https://json-schema.org/keyword/additionalProperties", additionalPropertiesNormalizationHandler);
8788
setNormalizationHandler("https://json-schema.org/keyword/allOf", allOfNormalizationHandler);
8889
setNormalizationHandler("https://json-schema.org/keyword/anyOf", anyOfNormalizationHandler);
90+
setNormalizationHandler("https://json-schema.org/keyword/comment", commentNormalizationHandler);
8991
setNormalizationHandler("https://json-schema.org/keyword/const", constNormalizationHandler);
9092
setNormalizationHandler("https://json-schema.org/keyword/contains", containsNormalizationHandler);
9193
setNormalizationHandler("https://json-schema.org/keyword/draft-06/contains", containsDraft06NormalizationHandler);
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
/**
2+
* @import { NormalizationHandler } from "../index.d.ts"
3+
*/
4+
5+
/** @type NormalizationHandler */
6+
const commentNormalizationHandler = {
7+
evaluate() {
8+
}
9+
};
10+
11+
export default commentNormalizationHandler;

src/test-suite/tests/comment.json

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{
2+
"$schema": "../test-suite.schema.json",
3+
4+
"description": "The comment keyword is ignored",
5+
"tests": [
6+
{
7+
"description": "format",
8+
"schema": {
9+
"$comment":"this is a comment",
10+
"type":"object"
11+
},
12+
"instance": {},
13+
"errors": [
14+
]
15+
}
16+
]
17+
}

0 commit comments

Comments
 (0)