infra: second round of PR review fixes

- mainnetDockerTags.feeQuoting bumped from the old standalone
  hyperlane-fee-quoting tag (which does not exist in the node-services
  repo) to 1a19513-20260413-090011, a node-services build from after
  fee-quoting was bundled into the Dockerfile. Fixes a guaranteed
  ImagePullBackOff after the migration.
- Add FEE_QUOTING to NODE_SERVICE_NAMES; thread it through
  FeeQuotingHelmManager.helmValues and the chart deployment template
  (SERVICE_NAME now reads .Values.serviceName with fee-quoting fallback),
  matching the pattern rebalancer and warp-monitor use.
- Drop two unnecessary casts in attestation.ts — the `'key' in err`
  guard already narrows in modern TS, per review feedback.

Author: paulbalaji

typescript/infra/config/docker.ts

@@ -51,7 +51,11 @@ export const mainnetDockerTags: MainnetDockerTags = {
   keyFunder: '3b17358-20260315-183126',
   warpMonitor: '3b17358-20260315-183126',
   rebalancer: '1a19513-20260413-090011',
-  feeQuoting: '12d899d-20260325-184337',
+  // Bumped from the old standalone hyperlane-fee-quoting tag when the
+  // service was migrated onto hyperlane-node-services. Points at a
+  // post-migration node-services build that includes the fee-quoting
+  // bundle; bump again after the next signed main build lands.
+  feeQuoting: '1a19513-20260413-090011',
 };
 
 export const testnetDockerTags: BaseDockerTags = {

typescript/infra/helm/fee-quoting/templates/deployment.yaml

@@ -53,7 +53,7 @@ spec:
                 name: {{ .Chart.Name }}-secrets
           env:
             - name: SERVICE_NAME
-              value: fee-quoting
+              value: {{ .Values.serviceName | default "fee-quoting" | quote }}
             - name: REGISTRY_URI
               value: {{ .Values.hyperlane.registryUri | quote }}
 {{- with .Values.env }}

typescript/infra/src/fee-quoting/helm.ts

@@ -4,6 +4,7 @@ import { DEFAULT_GITHUB_REGISTRY } from '@hyperlane-xyz/registry';
 
 import { DockerImageRepos, mainnetDockerTags } from '../../config/docker.js';
 import { DeployEnvironment } from '../config/deploy-environment.js';
+import { NODE_SERVICE_NAMES } from '../utils/consts.js';
 import { HelmManager } from '../utils/helm.js';
 import { getInfraPath } from '../utils/utils.js';
 import { readYaml } from '@hyperlane-xyz/utils/fs';
@@ -46,6 +47,7 @@ export class FeeQuotingHelmManager extends HelmManager {
         repository: DockerImageRepos.NODE_SERVICES,
         tag: mainnetDockerTags.feeQuoting,
       },
+      serviceName: NODE_SERVICE_NAMES.FEE_QUOTING,
       hyperlane: {
         ...envValues.hyperlane,
         runEnv: this.environment,

typescript/infra/src/utils/attestation.ts

@@ -67,7 +67,7 @@ function isNodeErrorCode(err: unknown, code: string): boolean {
     typeof err === 'object' &&
     err !== null &&
     'code' in err &&
-    (err as { code: unknown }).code === code
+    err.code === code
   );
 }
 
@@ -131,7 +131,7 @@ function extractFinishedOn(rawJson: string): FinishedOnResult {
       for (const t of tlogEntries) {
         const raw =
           typeof t === 'object' && t !== null && 'integratedTime' in t
-            ? (t as { integratedTime: unknown }).integratedTime
+            ? t.integratedTime
             : undefined;
         const seconds =
           typeof raw === 'string'

typescript/infra/src/utils/consts.ts

@@ -13,6 +13,7 @@ export const NODE_SERVICE_NAMES = {
   CCIP_SERVER: 'ccip-server',
   KEYFUNDER: 'keyfunder',
   RELAYER: 'relayer',
+  FEE_QUOTING: 'fee-quoting',
 } as const;
 /**
  * Get validator alias from defaultMultisigConfigs if available