Commit 3862aac
committed
fix(utils): restore optional logging peer deps
Bugbot flagged (and reproduction confirmed) that dropping the optional
peer deps broke GCP logger init at runtime. `await import()` in
utils/logging.ts resolves from utils' own module path, and pnpm's
isolated linker only links a transitive dep into utils/node_modules if
utils itself declares it. Without the peer, `ERR_MODULE_NOT_FOUND` is
swallowed by the try/catch and services silently log without GCP
structured fields.
Restoring the optional peers re-links the packages into utils'
node_modules when a consumer declares them directly. No API churn,
both the GCP and pino-pretty regressions are addressed.1 parent a7bf9ba commit 3862aac
4 files changed
Lines changed: 20 additions & 5 deletions
File tree
- .changeset
- typescript/utils
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
77 | 89 | | |
78 | 90 | | |
79 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | 161 | | |
165 | | - | |
| 162 | + | |
166 | 163 | | |
167 | 164 | | |
168 | 165 | | |
| |||
0 commit comments