chore: resolve comments

Author: yjamin

rust/main/chains/hyperlane-aleo/src/provider.rs

@@ -1,3 +1,7 @@
+pub use aleo::*;
+pub use base::*;
+pub use traits::*;
+
 mod aleo;
 mod base;
 mod traits;
@@ -6,7 +10,3 @@ mod traits;
 mod mock;
 #[cfg(test)]
 mod tests;
-
-pub use aleo::*;
-pub use base::*;
-pub use traits::*;

rust/main/chains/hyperlane-aleo/src/types.rs

@@ -4,8 +4,11 @@ use snarkvm::{
 };
 use snarkvm_console_account::Field;
 
-/// Default Network that we go to
-/// We need this as aleo annotates every type - even types that don't change with a different network
+// This actually works for all networks. I've raised this with the Aleo team, but the type annotation here doesn't actually change the underlying type.
+// The Aleo VM types all inherit a generic Network type, but that Type is not relevant for many structs of Aleo and is supposed to be more of an additional information for the internal VM processing.
+// They need this, because they generate ZK Proofs differently for different networks but the actual data of these types are the same across all Networks.
+// We pass CurrentNetwork into a lot of types, because we don't have to generate ZK Proofs in almost every situation - except when submitting a TX. There is one exception to this and that is when parsing/handling with Blocks.
+// The Block type verifies its validity on creation and that changes based on the Network type, thats why we have to pass the correct Type when dealing with blocks.
 pub(crate) type CurrentNetwork = MainnetV0;
 /// TxID Type
 pub(crate) type TxID = AleoID<Field<TestnetV0>, { hrp2!("at") }>;

rust/main/chains/hyperlane-aleo/src/utils.rs

@@ -11,6 +11,11 @@ pub(crate) fn get_tx_id(hash: impl Into<H256>) -> ChainResult<TxID> {
 /// Convert a TxID or any other struct that implements ToBytes to H256
 pub(crate) fn to_h256<T: ToBytes>(id: T) -> ChainResult<H256> {
     let bytes = id.to_bytes_le().map_err(HyperlaneAleoError::from)?;
+    if bytes.len() != 32 {
+        return Err(hyperlane_core::ChainCommunicationError::from_other_str(
+            &format! {"Invalid length for H256 conversion: expected 32, got {}", bytes.len()},
+        ));
+    }
     Ok(H256::from_slice(&bytes))
 }
 
@@ -23,6 +28,17 @@ mod tests {
     use super::*;
     use crate::CurrentNetwork;
 
+    struct TestStruct {}
+
+    impl ToBytes for TestStruct {
+        fn write_le<W: std::io::Write>(&self, writer: W) -> std::io::Result<()>
+        where
+            Self: Sized,
+        {
+            [0u8; 33].write_le(writer)
+        }
+    }
+
     #[test]
     fn test_get_tx_id() {
         let hash = H256::zero();
@@ -45,4 +61,15 @@ mod tests {
                 .unwrap();
         assert_eq!(h256.as_bytes(), expected_bytes.as_slice());
     }
+
+    #[test]
+    fn test_to_h256_with_custom_struct() {
+        let test_struct = TestStruct {};
+        let h256 = super::to_h256(test_struct);
+        assert!(h256.is_err());
+        assert_eq!(
+            h256.err().unwrap().to_string(),
+            "Invalid length for H256 conversion: expected 32, got 33"
+        );
+    }
 }